Skip to content

Commit a7749e9

Browse files
committed
Add system test for 'Sink.reload'.
Uses the Bigquery destination because that one runs quickest.
1 parent 79c8e2c commit a7749e9

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

system_tests/logging_.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def test_create_sink_storage_bucket(self):
150150
self.to_delete.append(sink)
151151
self.assertTrue(sink.exists())
152152

153-
def test_create_sink_bigquery_dataset(self):
153+
def _init_bigquery_dataset(self):
154154
from gcloud import bigquery
155155
from gcloud.bigquery.dataset import AccessGrant
156156
DATASET_URI = 'bigquery.googleapis.com/projects/%s/datasets/%s' % (
@@ -168,10 +168,24 @@ def test_create_sink_bigquery_dataset(self):
168168
'WRITER', 'groupByEmail', '[email protected]'))
169169
dataset.access_grants = grants
170170
dataset.update()
171+
return DATASET_URI
171172

172-
sink = Config.CLIENT.sink(
173-
DEFAULT_SINK_NAME, DEFAULT_FILTER, DATASET_URI)
173+
def test_create_sink_bigquery_dataset(self):
174+
uri = self._init_bigquery_dataset()
175+
sink = Config.CLIENT.sink(DEFAULT_SINK_NAME, DEFAULT_FILTER, uri)
174176
self.assertFalse(sink.exists())
175177
sink.create()
176178
self.to_delete.append(sink)
177179
self.assertTrue(sink.exists())
180+
181+
def test_reload_sink(self):
182+
uri = self._init_bigquery_dataset()
183+
sink = Config.CLIENT.sink(DEFAULT_SINK_NAME, DEFAULT_FILTER, uri)
184+
self.assertFalse(sink.exists())
185+
sink.create()
186+
self.to_delete.append(sink)
187+
sink.filter_ = 'BOGUS FILTER'
188+
sink.destination = 'BOGUS DESTINATION'
189+
sink.reload()
190+
self.assertEqual(sink.filter_, DEFAULT_FILTER)
191+
self.assertEqual(sink.destination, uri)

0 commit comments

Comments
 (0)