Skip to content

Commit 4c1074f

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
fix: Add async context manager return types (#351)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent e8cafc1 commit 4c1074f

File tree

6 files changed

+27
-201
lines changed

6 files changed

+27
-201
lines changed

‎packages/google-cloud-tasks/google/cloud/tasks_v2/services/cloud_tasks/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2316,7 +2316,7 @@ async def sample_run_task():
23162316
# Done; return the response.
23172317
return response
23182318

2319-
async def __aenter__(self):
2319+
async def __aenter__(self) -> "CloudTasksAsyncClient":
23202320
return self
23212321

23222322
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-tasks/google/cloud/tasks_v2beta2/services/cloud_tasks/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2865,7 +2865,7 @@ async def sample_run_task():
28652865
# Done; return the response.
28662866
return response
28672867

2868-
async def __aenter__(self):
2868+
async def __aenter__(self) -> "CloudTasksAsyncClient":
28692869
return self
28702870

28712871
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-tasks/google/cloud/tasks_v2beta3/services/cloud_tasks/async_client.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2318,7 +2318,7 @@ async def sample_run_task():
23182318
# Done; return the response.
23192319
return response
23202320

2321-
async def __aenter__(self):
2321+
async def __aenter__(self) -> "CloudTasksAsyncClient":
23222322
return self
23232323

23242324
async def __aexit__(self, exc_type, exc, tb):

‎packages/google-cloud-tasks/tests/unit/gapic/tasks_v2/test_cloud_tasks.py‎

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1105,9 +1105,11 @@ async def test_list_queues_async_pages():
11051105
RuntimeError,
11061106
)
11071107
pages = []
1108-
async for page_ in (
1108+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1109+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1110+
async for page_ in ( # pragma: no branch
11091111
await client.list_queues(request={})
1110-
).pages: # pragma: no branch
1112+
).pages:
11111113
pages.append(page_)
11121114
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11131115
assert page_.raw_page.next_page_token == token
@@ -3932,9 +3934,11 @@ async def test_list_tasks_async_pages():
39323934
RuntimeError,
39333935
)
39343936
pages = []
3935-
async for page_ in (
3937+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
3938+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
3939+
async for page_ in ( # pragma: no branch
39363940
await client.list_tasks(request={})
3937-
).pages: # pragma: no branch
3941+
).pages:
39383942
pages.append(page_)
39393943
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
39403944
assert page_.raw_page.next_page_token == token
@@ -3965,9 +3969,6 @@ def test_get_task(request_type, transport: str = "grpc"):
39653969
dispatch_count=1496,
39663970
response_count=1527,
39673971
view=task.Task.View.BASIC,
3968-
app_engine_http_request=target.AppEngineHttpRequest(
3969-
http_method=target.HttpMethod.POST
3970-
),
39713972
)
39723973
response = client.get_task(request)
39733974

@@ -4208,9 +4209,6 @@ def test_create_task(request_type, transport: str = "grpc"):
42084209
dispatch_count=1496,
42094210
response_count=1527,
42104211
view=gct_task.Task.View.BASIC,
4211-
app_engine_http_request=target.AppEngineHttpRequest(
4212-
http_method=target.HttpMethod.POST
4213-
),
42144212
)
42154213
response = client.create_task(request)
42164214

@@ -4681,9 +4679,6 @@ def test_run_task(request_type, transport: str = "grpc"):
46814679
dispatch_count=1496,
46824680
response_count=1527,
46834681
view=task.Task.View.BASIC,
4684-
app_engine_http_request=target.AppEngineHttpRequest(
4685-
http_method=target.HttpMethod.POST
4686-
),
46874682
)
46884683
response = client.run_task(request)
46894684

@@ -8372,9 +8367,6 @@ def test_get_task_rest(request_type):
83728367
dispatch_count=1496,
83738368
response_count=1527,
83748369
view=task.Task.View.BASIC,
8375-
app_engine_http_request=target.AppEngineHttpRequest(
8376-
http_method=target.HttpMethod.POST
8377-
),
83788370
)
83798371

83808372
# Wrap the value into a proper Response obj
@@ -8649,9 +8641,6 @@ def test_create_task_rest(request_type):
86498641
dispatch_count=1496,
86508642
response_count=1527,
86518643
view=gct_task.Task.View.BASIC,
8652-
app_engine_http_request=target.AppEngineHttpRequest(
8653-
http_method=target.HttpMethod.POST
8654-
),
86558644
)
86568645

86578646
# Wrap the value into a proper Response obj
@@ -9188,9 +9177,6 @@ def test_run_task_rest(request_type):
91889177
dispatch_count=1496,
91899178
response_count=1527,
91909179
view=task.Task.View.BASIC,
9191-
app_engine_http_request=target.AppEngineHttpRequest(
9192-
http_method=target.HttpMethod.POST
9193-
),
91949180
)
91959181

91969182
# Wrap the value into a proper Response obj

‎packages/google-cloud-tasks/tests/unit/gapic/tasks_v2beta2/test_cloud_tasks.py‎

Lines changed: 8 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -1105,9 +1105,11 @@ async def test_list_queues_async_pages():
11051105
RuntimeError,
11061106
)
11071107
pages = []
1108-
async for page_ in (
1108+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1109+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1110+
async for page_ in ( # pragma: no branch
11091111
await client.list_queues(request={})
1110-
).pages: # pragma: no branch
1112+
).pages:
11111113
pages.append(page_)
11121114
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11131115
assert page_.raw_page.next_page_token == token
@@ -1136,11 +1138,6 @@ def test_get_queue(request_type, transport: str = "grpc"):
11361138
call.return_value = queue.Queue(
11371139
name="name_value",
11381140
state=queue.Queue.State.RUNNING,
1139-
app_engine_http_target=target.AppEngineHttpTarget(
1140-
app_engine_routing_override=target.AppEngineRouting(
1141-
service="service_value"
1142-
)
1143-
),
11441141
)
11451142
response = client.get_queue(request)
11461143

@@ -1373,11 +1370,6 @@ def test_create_queue(request_type, transport: str = "grpc"):
13731370
call.return_value = gct_queue.Queue(
13741371
name="name_value",
13751372
state=gct_queue.Queue.State.RUNNING,
1376-
app_engine_http_target=target.AppEngineHttpTarget(
1377-
app_engine_routing_override=target.AppEngineRouting(
1378-
service="service_value"
1379-
)
1380-
),
13811373
)
13821374
response = client.create_queue(request)
13831375

@@ -1620,11 +1612,6 @@ def test_update_queue(request_type, transport: str = "grpc"):
16201612
call.return_value = gct_queue.Queue(
16211613
name="name_value",
16221614
state=gct_queue.Queue.State.RUNNING,
1623-
app_engine_http_target=target.AppEngineHttpTarget(
1624-
app_engine_routing_override=target.AppEngineRouting(
1625-
service="service_value"
1626-
)
1627-
),
16281615
)
16291616
response = client.update_queue(request)
16301617

@@ -2087,11 +2074,6 @@ def test_purge_queue(request_type, transport: str = "grpc"):
20872074
call.return_value = queue.Queue(
20882075
name="name_value",
20892076
state=queue.Queue.State.RUNNING,
2090-
app_engine_http_target=target.AppEngineHttpTarget(
2091-
app_engine_routing_override=target.AppEngineRouting(
2092-
service="service_value"
2093-
)
2094-
),
20952077
)
20962078
response = client.purge_queue(request)
20972079

@@ -2324,11 +2306,6 @@ def test_pause_queue(request_type, transport: str = "grpc"):
23242306
call.return_value = queue.Queue(
23252307
name="name_value",
23262308
state=queue.Queue.State.RUNNING,
2327-
app_engine_http_target=target.AppEngineHttpTarget(
2328-
app_engine_routing_override=target.AppEngineRouting(
2329-
service="service_value"
2330-
)
2331-
),
23322309
)
23332310
response = client.pause_queue(request)
23342311

@@ -2561,11 +2538,6 @@ def test_resume_queue(request_type, transport: str = "grpc"):
25612538
call.return_value = queue.Queue(
25622539
name="name_value",
25632540
state=queue.Queue.State.RUNNING,
2564-
app_engine_http_target=target.AppEngineHttpTarget(
2565-
app_engine_routing_override=target.AppEngineRouting(
2566-
service="service_value"
2567-
)
2568-
),
25692541
)
25702542
response = client.resume_queue(request)
25712543

@@ -3962,9 +3934,11 @@ async def test_list_tasks_async_pages():
39623934
RuntimeError,
39633935
)
39643936
pages = []
3965-
async for page_ in (
3937+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
3938+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
3939+
async for page_ in ( # pragma: no branch
39663940
await client.list_tasks(request={})
3967-
).pages: # pragma: no branch
3941+
).pages:
39683942
pages.append(page_)
39693943
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
39703944
assert page_.raw_page.next_page_token == token
@@ -3993,9 +3967,6 @@ def test_get_task(request_type, transport: str = "grpc"):
39933967
call.return_value = task.Task(
39943968
name="name_value",
39953969
view=task.Task.View.BASIC,
3996-
app_engine_http_request=target.AppEngineHttpRequest(
3997-
http_method=target.HttpMethod.POST
3998-
),
39993970
)
40003971
response = client.get_task(request)
40013972

@@ -4228,9 +4199,6 @@ def test_create_task(request_type, transport: str = "grpc"):
42284199
call.return_value = gct_task.Task(
42294200
name="name_value",
42304201
view=gct_task.Task.View.BASIC,
4231-
app_engine_http_request=target.AppEngineHttpRequest(
4232-
http_method=target.HttpMethod.POST
4233-
),
42344202
)
42354203
response = client.create_task(request)
42364204

@@ -5159,9 +5127,6 @@ def test_renew_lease(request_type, transport: str = "grpc"):
51595127
call.return_value = task.Task(
51605128
name="name_value",
51615129
view=task.Task.View.BASIC,
5162-
app_engine_http_request=target.AppEngineHttpRequest(
5163-
http_method=target.HttpMethod.POST
5164-
),
51655130
)
51665131
response = client.renew_lease(request)
51675132

@@ -5414,9 +5379,6 @@ def test_cancel_lease(request_type, transport: str = "grpc"):
54145379
call.return_value = task.Task(
54155380
name="name_value",
54165381
view=task.Task.View.BASIC,
5417-
app_engine_http_request=target.AppEngineHttpRequest(
5418-
http_method=target.HttpMethod.POST
5419-
),
54205382
)
54215383
response = client.cancel_lease(request)
54225384

@@ -5659,9 +5621,6 @@ def test_run_task(request_type, transport: str = "grpc"):
56595621
call.return_value = task.Task(
56605622
name="name_value",
56615623
view=task.Task.View.BASIC,
5662-
app_engine_http_request=target.AppEngineHttpRequest(
5663-
http_method=target.HttpMethod.POST
5664-
),
56655624
)
56665625
response = client.run_task(request)
56675626

@@ -6232,11 +6191,6 @@ def test_get_queue_rest(request_type):
62326191
return_value = queue.Queue(
62336192
name="name_value",
62346193
state=queue.Queue.State.RUNNING,
6235-
app_engine_http_target=target.AppEngineHttpTarget(
6236-
app_engine_routing_override=target.AppEngineRouting(
6237-
service="service_value"
6238-
)
6239-
),
62406194
)
62416195

62426196
# Wrap the value into a proper Response obj
@@ -6539,11 +6493,6 @@ def test_create_queue_rest(request_type):
65396493
return_value = gct_queue.Queue(
65406494
name="name_value",
65416495
state=gct_queue.Queue.State.RUNNING,
6542-
app_engine_http_target=target.AppEngineHttpTarget(
6543-
app_engine_routing_override=target.AppEngineRouting(
6544-
service="service_value"
6545-
)
6546-
),
65476496
)
65486497

65496498
# Wrap the value into a proper Response obj
@@ -6893,11 +6842,6 @@ def test_update_queue_rest(request_type):
68936842
return_value = gct_queue.Queue(
68946843
name="name_value",
68956844
state=gct_queue.Queue.State.RUNNING,
6896-
app_engine_http_target=target.AppEngineHttpTarget(
6897-
app_engine_routing_override=target.AppEngineRouting(
6898-
service="service_value"
6899-
)
6900-
),
69016845
)
69026846

69036847
# Wrap the value into a proper Response obj
@@ -7451,11 +7395,6 @@ def test_purge_queue_rest(request_type):
74517395
return_value = queue.Queue(
74527396
name="name_value",
74537397
state=queue.Queue.State.RUNNING,
7454-
app_engine_http_target=target.AppEngineHttpTarget(
7455-
app_engine_routing_override=target.AppEngineRouting(
7456-
service="service_value"
7457-
)
7458-
),
74597398
)
74607399

74617400
# Wrap the value into a proper Response obj
@@ -7721,11 +7660,6 @@ def test_pause_queue_rest(request_type):
77217660
return_value = queue.Queue(
77227661
name="name_value",
77237662
state=queue.Queue.State.RUNNING,
7724-
app_engine_http_target=target.AppEngineHttpTarget(
7725-
app_engine_routing_override=target.AppEngineRouting(
7726-
service="service_value"
7727-
)
7728-
),
77297663
)
77307664

77317665
# Wrap the value into a proper Response obj
@@ -7991,11 +7925,6 @@ def test_resume_queue_rest(request_type):
79917925
return_value = queue.Queue(
79927926
name="name_value",
79937927
state=queue.Queue.State.RUNNING,
7994-
app_engine_http_target=target.AppEngineHttpTarget(
7995-
app_engine_routing_override=target.AppEngineRouting(
7996-
service="service_value"
7997-
)
7998-
),
79997928
)
80007929

80017930
# Wrap the value into a proper Response obj
@@ -9428,9 +9357,6 @@ def test_get_task_rest(request_type):
94289357
return_value = task.Task(
94299358
name="name_value",
94309359
view=task.Task.View.BASIC,
9431-
app_engine_http_request=target.AppEngineHttpRequest(
9432-
http_method=target.HttpMethod.POST
9433-
),
94349360
)
94359361

94369362
# Wrap the value into a proper Response obj
@@ -9701,9 +9627,6 @@ def test_create_task_rest(request_type):
97019627
return_value = gct_task.Task(
97029628
name="name_value",
97039629
view=gct_task.Task.View.BASIC,
9704-
app_engine_http_request=target.AppEngineHttpRequest(
9705-
http_method=target.HttpMethod.POST
9706-
),
97079630
)
97089631

97099632
# Wrap the value into a proper Response obj
@@ -10778,9 +10701,6 @@ def test_renew_lease_rest(request_type):
1077810701
return_value = task.Task(
1077910702
name="name_value",
1078010703
view=task.Task.View.BASIC,
10781-
app_engine_http_request=target.AppEngineHttpRequest(
10782-
http_method=target.HttpMethod.POST
10783-
),
1078410704
)
1078510705

1078610706
# Wrap the value into a proper Response obj
@@ -11065,9 +10985,6 @@ def test_cancel_lease_rest(request_type):
1106510985
return_value = task.Task(
1106610986
name="name_value",
1106710987
view=task.Task.View.BASIC,
11068-
app_engine_http_request=target.AppEngineHttpRequest(
11069-
http_method=target.HttpMethod.POST
11070-
),
1107110988
)
1107210989

1107310990
# Wrap the value into a proper Response obj
@@ -11349,9 +11266,6 @@ def test_run_task_rest(request_type):
1134911266
return_value = task.Task(
1135011267
name="name_value",
1135111268
view=task.Task.View.BASIC,
11352-
app_engine_http_request=target.AppEngineHttpRequest(
11353-
http_method=target.HttpMethod.POST
11354-
),
1135511269
)
1135611270

1135711271
# Wrap the value into a proper Response obj

0 commit comments

Comments
 (0)