Skip to content

Commit 1ff7708

Browse files
Make exclude_from_indexes a set, and public API. (#3756)
1 parent aaaaf7d commit 1ff7708

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

datastore/google/cloud/datastore/entity.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,9 @@ class Entity(dict):
129129
def __init__(self, key=None, exclude_from_indexes=()):
130130
super(Entity, self).__init__()
131131
self.key = key
132-
self._exclude_from_indexes = set(_ensure_tuple_or_list(
132+
self.exclude_from_indexes = set(_ensure_tuple_or_list(
133133
'exclude_from_indexes', exclude_from_indexes))
134+
"""Names of fields which are *not* to be indexed for this entity."""
134135
# NOTE: This will be populated when parsing a protobuf in
135136
# google.cloud.datastore.helpers.entity_from_protobuf.
136137
self._meanings = {}
@@ -148,7 +149,7 @@ def __eq__(self, other):
148149
return False
149150

150151
return (self.key == other.key and
151-
self._exclude_from_indexes == other._exclude_from_indexes and
152+
self.exclude_from_indexes == other.exclude_from_indexes and
152153
self._meanings == other._meanings and
153154
super(Entity, self).__eq__(other))
154155

@@ -176,15 +177,6 @@ def kind(self):
176177
if self.key:
177178
return self.key.kind
178179

179-
@property
180-
def exclude_from_indexes(self):
181-
"""Names of fields which are *not* to be indexed for this entity.
182-
183-
:rtype: sequence of field names
184-
:returns: The set of fields excluded from indexes.
185-
"""
186-
return frozenset(self._exclude_from_indexes)
187-
188180
def __repr__(self):
189181
if self.key:
190182
return '<Entity%s %s>' % (self.key._flat_path,

0 commit comments

Comments
 (0)