Skip to content

Commit 0e0509f

Browse files
committed
Adding Transaction.dataset_id property.
1 parent f8a55f1 commit 0e0509f

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

gcloud/datastore/test_transaction.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ def test_ctor(self):
4444
_DATASET = 'DATASET'
4545
connection = _Connection()
4646
xact = self._makeOne(dataset_id=_DATASET, connection=connection)
47-
self.assertEqual(xact._dataset_id, _DATASET)
48-
self.assertEqual(xact._connection, connection)
47+
self.assertEqual(xact.dataset_id, _DATASET)
48+
self.assertEqual(xact.connection, connection)
4949
self.assertEqual(xact.id, None)
5050
self.assertTrue(isinstance(xact.mutation, Mutation))
5151
self.assertEqual(len(xact._auto_id_entities), 0)
@@ -61,8 +61,8 @@ def test_ctor_with_env(self):
6161
CONNECTION=CONNECTION):
6262
transaction = self._makeOne()
6363

64-
self.assertEqual(transaction._dataset_id, DATASET_ID)
65-
self.assertEqual(transaction._connection, CONNECTION)
64+
self.assertEqual(transaction.dataset_id, DATASET_ID)
65+
self.assertEqual(transaction.connection, CONNECTION)
6666

6767
def test_add_auto_id_entity(self):
6868
entity = _Entity()

gcloud/datastore/transaction.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,18 @@ def __init__(self, dataset_id=None, connection=None):
143143
self._mutation = datastore_pb.Mutation()
144144
self._auto_id_entities = []
145145

146+
@property
147+
def dataset_id(self):
148+
"""Getter for dataset ID in which the transaction will run.
149+
150+
:rtype: :class:`str`
151+
:returns: The dataset ID in which the transaction will run.
152+
"""
153+
return self._dataset_id
154+
146155
@property
147156
def connection(self):
148-
"""Getter for current connection over which the transaction will run.
157+
"""Getter for connection over which the transaction will run.
149158
150159
:rtype: :class:`gcloud.datastore.connection.Connection`
151160
:returns: The connection over which the transaction will run.

0 commit comments

Comments
 (0)