Small pylint clean-up.

- Increasing test lines limit to 1900 and removing a
  line limit ignore at the top of the file
- Disabling no-name-in-module since requiring 100%
  code coverage guarantees we exercise all imports
- Making remaining disables use verbose names instead of
  short names
- Locally re-enabling too-many-statements in
  gcloud/bigquery/test_table.py (was disabled at a scope
  but never re-enabled)

Author: dhermes

gcloud/bigquery/table.py

@@ -717,7 +717,8 @@ def insert_data(self,
 
         return errors
 
-    def upload_from_file(self,  # pylint: disable=R0913,R0914
+    # pylint: disable=too-many-arguments,too-many-locals
+    def upload_from_file(self,
                          file_obj,
                          source_format,
                          rewind=False,
@@ -890,9 +891,10 @@ def upload_from_file(self,  # pylint: disable=R0913,R0914
                           six.string_types):  # pragma: NO COVER  Python3
             response_content = response_content.decode('utf-8')
         return client.job_from_resource(json.loads(response_content))
+    # pylint: enable=too-many-arguments,too-many-locals
 
 
-def _configure_job_metadata(metadata,  # pylint: disable=R0913
+def _configure_job_metadata(metadata,  # pylint: disable=too-many-arguments
                             allow_jagged_rows,
                             allow_quoted_newlines,
                             create_disposition,

gcloud/bigquery/test_table.py

@@ -1404,7 +1404,7 @@ def test_upload_from_file_w_bound_client_multipart(self):
         payload_lines = app_msg._payload.rstrip().splitlines()
         self.assertEqual(payload_lines, body_lines)
 
-    # pylint: disable=R0915
+    # pylint: disable=too-many-statements
     def test_upload_from_file_w_explicit_client_resumable(self):
         import json
         from six.moves.http_client import OK
@@ -1490,6 +1490,7 @@ class _UploadConfig(object):
                          'bytes 0-%d/%d' % (length - 1, length))
         self.assertEqual(headers['content-length'], '%d' % (length,))
         self.assertEqual(req['body'], BODY)
+    # pylint: enable=too-many-statements
 
 
 class Test_parse_schema_resource(unittest2.TestCase, _SchemaBase):
@@ -1606,7 +1607,7 @@ def __init__(self, project='project', connection=None):
         self.project = project
         self.connection = connection
 
-    def job_from_resource(self, resource):  # pylint: disable=W0613
+    def job_from_resource(self, resource):  # pylint: disable=unused-argument
         return self._job
 
 

gcloud/streaming/test_transfer.py

@@ -1,4 +1,3 @@
-# pylint: disable=C0302
 import unittest2
 
 

scripts/pylintrc_default

@@ -87,6 +87,9 @@ load-plugins=pylint.extensions.check_docs
 #                                      """Hi everyone"""
 #                          and thus causes subsequent imports to be
 #                          diagnosed as out-of-order.
+# - no-name-in-module: Error gives a lot of false positives for names which
+#                      are defined dynamically. Also, any truly missing names
+#                      will be detected by our 100% code coverage.
 disable =
     maybe-no-member,
     no-member,
@@ -95,6 +98,7 @@ disable =
     star-args,
     redefined-variable-type,
     wrong-import-position,
+    no-name-in-module,
 
 
 [REPORTS]

scripts/run_pylint.py

@@ -65,7 +65,7 @@
 }
 TEST_RC_REPLACEMENTS = {
     'FORMAT': {
-        'max-module-lines': 1700,
+        'max-module-lines': 1900,
     },
 }
 

system_tests/bigtable.py

@@ -231,10 +231,8 @@ def test_create_table(self):
         self.assertEqual(sorted_tables, expected_tables)
 
     def test_rename_table(self):
-        # pylint: disable=no-name-in-module
         from grpc.beta import interfaces
         from grpc.framework.interfaces.face import face
-        # pylint: enable=no-name-in-module
 
         temp_table_id = 'foo-bar-baz-table'
         temp_table = Config.CLUSTER.table(temp_table_id)