Skip to content

Commit be595ce

Browse files
JustinBeckwithJustinBeckwith
authored
Fix the linter (#16)
1 parent 3233862 commit be595ce

File tree

3 files changed

+38
-37
lines changed

3 files changed

+38
-37
lines changed

‎packages/google-cloud-asset/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../",
4141
"system-test": "mocha system-test/*.js smoke-test/*.js --timeout 600000",
4242
"test-no-cover": "mocha test/*.js",
43-
"test": "npm run cover"
43+
"test": "npm run cover",
44+
"fix": "eslint --fix '**/*.js' && npm run prettier"
4445
},
4546
"dependencies": {
4647
"google-gax": "^0.20.0",

‎packages/google-cloud-asset/src/v1beta1/asset_service_client.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ class AssetServiceClient {
7272
// Create a `gaxGrpc` object, with any grpc-specific options
7373
// sent to the client.
7474
opts.scopes = this.constructor.scopes;
75-
let gaxGrpc = new gax.GrpcClient(opts);
75+
const gaxGrpc = new gax.GrpcClient(opts);
7676

7777
// Save the auth object to the client, for use by other methods.
7878
this.auth = gaxGrpc.auth;
7979

8080
// Determine the client header string.
81-
let clientHeader = [
81+
const clientHeader = [
8282
`gl-node/${process.version}`,
8383
`grpc/${gaxGrpc.grpcVersion}`,
8484
`gax/${gax.version}`,
@@ -89,7 +89,7 @@ class AssetServiceClient {
8989
}
9090

9191
// Load the applicable protos.
92-
let protos = merge(
92+
const protos = merge(
9393
{},
9494
gaxGrpc.loadProto(
9595
path.join(__dirname, '..', '..', 'protos'),
@@ -123,10 +123,10 @@ class AssetServiceClient {
123123
grpc: gaxGrpc.grpc,
124124
}).operationsClient(opts);
125125

126-
let exportAssetsResponse = protoFilesRoot.lookup(
126+
const exportAssetsResponse = protoFilesRoot.lookup(
127127
'google.cloud.asset.v1beta1.ExportAssetsResponse'
128128
);
129-
let exportAssetsMetadata = protoFilesRoot.lookup(
129+
const exportAssetsMetadata = protoFilesRoot.lookup(
130130
'google.cloud.asset.v1beta1.ExportAssetsRequest'
131131
);
132132

@@ -139,7 +139,7 @@ class AssetServiceClient {
139139
};
140140

141141
// Put together the default options sent with requests.
142-
let defaults = gaxGrpc.constructSettings(
142+
const defaults = gaxGrpc.constructSettings(
143143
'google.cloud.asset.v1beta1.AssetService',
144144
gapicConfig,
145145
opts.clientConfig,
@@ -153,20 +153,20 @@ class AssetServiceClient {
153153

154154
// Put together the "service stub" for
155155
// google.cloud.asset.v1beta1.AssetService.
156-
let assetServiceStub = gaxGrpc.createStub(
156+
const assetServiceStub = gaxGrpc.createStub(
157157
protos.google.cloud.asset.v1beta1.AssetService,
158158
opts
159159
);
160160

161161
// Iterate over each of the methods that the service provides
162162
// and create an API call method for each.
163-
let assetServiceStubMethods = ['exportAssets', 'batchGetAssetsHistory'];
164-
for (let methodName of assetServiceStubMethods) {
163+
const assetServiceStubMethods = ['exportAssets', 'batchGetAssetsHistory'];
164+
for (const methodName of assetServiceStubMethods) {
165165
this._innerApiCalls[methodName] = gax.createApiCall(
166166
assetServiceStub.then(
167167
stub =>
168168
function() {
169-
let args = Array.prototype.slice.call(arguments, 0);
169+
const args = Array.prototype.slice.call(arguments, 0);
170170
return stub[methodName].apply(stub, args);
171171
}
172172
),

‎packages/google-cloud-asset/test/gapic-v1beta1.js‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -18,28 +18,28 @@ const assert = require('assert');
1818

1919
const assetModule = require('../src');
2020

21-
let FAKE_STATUS_CODE = 1;
22-
let error = new Error();
21+
const FAKE_STATUS_CODE = 1;
22+
const error = new Error();
2323
error.code = FAKE_STATUS_CODE;
2424

2525
describe('AssetServiceClient', () => {
2626
describe('exportAssets', function() {
2727
it('invokes exportAssets without error', done => {
28-
let client = new assetModule.v1beta1.AssetServiceClient({
28+
const client = new assetModule.v1beta1.AssetServiceClient({
2929
credentials: {client_email: 'bogus', private_key: 'bogus'},
3030
projectId: 'bogus',
3131
});
3232

3333
// Mock request
34-
let formattedParent = client.projectPath('[PROJECT]');
35-
let outputConfig = {};
36-
let request = {
34+
const formattedParent = client.projectPath('[PROJECT]');
35+
const outputConfig = {};
36+
const request = {
3737
parent: formattedParent,
3838
outputConfig: outputConfig,
3939
};
4040

4141
// Mock response
42-
let expectedResponse = {};
42+
const expectedResponse = {};
4343

4444
// Mock Grpc layer
4545
client._innerApiCalls.exportAssets = mockLongRunningGrpcMethod(
@@ -50,7 +50,7 @@ describe('AssetServiceClient', () => {
5050
client
5151
.exportAssets(request)
5252
.then(responses => {
53-
let operation = responses[0];
53+
const operation = responses[0];
5454
return operation.promise();
5555
})
5656
.then(responses => {
@@ -63,15 +63,15 @@ describe('AssetServiceClient', () => {
6363
});
6464

6565
it('invokes exportAssets with error', done => {
66-
let client = new assetModule.v1beta1.AssetServiceClient({
66+
const client = new assetModule.v1beta1.AssetServiceClient({
6767
credentials: {client_email: 'bogus', private_key: 'bogus'},
6868
projectId: 'bogus',
6969
});
7070

7171
// Mock request
72-
let formattedParent = client.projectPath('[PROJECT]');
73-
let outputConfig = {};
74-
let request = {
72+
const formattedParent = client.projectPath('[PROJECT]');
73+
const outputConfig = {};
74+
const request = {
7575
parent: formattedParent,
7676
outputConfig: outputConfig,
7777
};
@@ -86,7 +86,7 @@ describe('AssetServiceClient', () => {
8686
client
8787
.exportAssets(request)
8888
.then(responses => {
89-
let operation = responses[0];
89+
const operation = responses[0];
9090
return operation.promise();
9191
})
9292
.then(() => {
@@ -100,7 +100,7 @@ describe('AssetServiceClient', () => {
100100
});
101101

102102
it('has longrunning decoder functions', () => {
103-
let client = new assetModule.v1beta1.AssetServiceClient({
103+
const client = new assetModule.v1beta1.AssetServiceClient({
104104
credentials: {client_email: 'bogus', private_key: 'bogus'},
105105
projectId: 'bogus',
106106
});
@@ -117,23 +117,23 @@ describe('AssetServiceClient', () => {
117117

118118
describe('batchGetAssetsHistory', () => {
119119
it('invokes batchGetAssetsHistory without error', done => {
120-
let client = new assetModule.v1beta1.AssetServiceClient({
120+
const client = new assetModule.v1beta1.AssetServiceClient({
121121
credentials: {client_email: 'bogus', private_key: 'bogus'},
122122
projectId: 'bogus',
123123
});
124124

125125
// Mock request
126-
let formattedParent = client.projectPath('[PROJECT]');
127-
let contentType = 'CONTENT_TYPE_UNSPECIFIED';
128-
let readTimeWindow = {};
129-
let request = {
126+
const formattedParent = client.projectPath('[PROJECT]');
127+
const contentType = 'CONTENT_TYPE_UNSPECIFIED';
128+
const readTimeWindow = {};
129+
const request = {
130130
parent: formattedParent,
131131
contentType: contentType,
132132
readTimeWindow: readTimeWindow,
133133
};
134134

135135
// Mock response
136-
let expectedResponse = {};
136+
const expectedResponse = {};
137137

138138
// Mock Grpc layer
139139
client._innerApiCalls.batchGetAssetsHistory = mockSimpleGrpcMethod(
@@ -149,16 +149,16 @@ describe('AssetServiceClient', () => {
149149
});
150150

151151
it('invokes batchGetAssetsHistory with error', done => {
152-
let client = new assetModule.v1beta1.AssetServiceClient({
152+
const client = new assetModule.v1beta1.AssetServiceClient({
153153
credentials: {client_email: 'bogus', private_key: 'bogus'},
154154
projectId: 'bogus',
155155
});
156156

157157
// Mock request
158-
let formattedParent = client.projectPath('[PROJECT]');
159-
let contentType = 'CONTENT_TYPE_UNSPECIFIED';
160-
let readTimeWindow = {};
161-
let request = {
158+
const formattedParent = client.projectPath('[PROJECT]');
159+
const contentType = 'CONTENT_TYPE_UNSPECIFIED';
160+
const readTimeWindow = {};
161+
const request = {
162162
parent: formattedParent,
163163
contentType: contentType,
164164
readTimeWindow: readTimeWindow,
@@ -197,7 +197,7 @@ function mockSimpleGrpcMethod(expectedRequest, response, error) {
197197
function mockLongRunningGrpcMethod(expectedRequest, response, error) {
198198
return request => {
199199
assert.deepStrictEqual(request, expectedRequest);
200-
let mockOperation = {
200+
const mockOperation = {
201201
promise: function() {
202202
return new Promise((resolve, reject) => {
203203
if (error) {

0 commit comments

Comments
 (0)