Skip to content

Commit 4337435

Browse files
jmdobryAce Nassri
authored andcommitted
Cleanup App Engine samples and re-work tests. (#354)
1 parent 914134a commit 4337435

File tree

2 files changed

+47
-8
lines changed

2 files changed

+47
-8
lines changed

packages/google-cloud-dns/samples/README.md

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,21 @@ anywhere in the world. Read more about [Google Cloud DNS][dns_docs].
1414
* [Setup](#setup)
1515
* [Samples](#samples)
1616
* [Zones](#zones)
17+
* [Running the tests](#running-the-tests)
1718

1819
## Setup
1920

20-
1. Read [Prerequisites][prereq] and [How to run a sample][run] first.
21-
1. Install dependencies:
21+
1. Read [Prerequisites][prereq] and [How to run a sample][run] first.
22+
1. Install dependencies:
23+
24+
With `npm`:
2225

2326
npm install
2427

28+
With `yarn`:
29+
30+
yarn install
31+
2532
[prereq]: ../README.md#prerequisities
2633
[run]: ../README.md#how-to-run-a-sample
2734

@@ -41,10 +48,25 @@ Options:
4148
--help Show help [boolean]
4249
4350
Examples:
44-
node zones list Lists all zones in the current project.
51+
node zones.js list Lists all zones in the current project.
4552
4653
For more information, see https://cloud.google.com/dns/docs
4754
```
4855

4956
[zones_docs]: https://cloud.google.com/dns/docs
5057
[zones_code]: zones.js
58+
59+
## Running the tests
60+
61+
1. Set the `GCLOUD_PROJECT` and `GOOGLE_APPLICATION_CREDENTIALS` environment
62+
variables.
63+
64+
1. Run the tests:
65+
66+
With `npm`:
67+
68+
npm test
69+
70+
With `yarn`:
71+
72+
yarn test

packages/google-cloud-dns/samples/package.json

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,33 @@
22
"name": "nodejs-docs-samples-dns",
33
"version": "0.0.1",
44
"private": true,
5-
"license": "Apache Version 2.0",
5+
"license": "Apache-2.0",
66
"author": "Google Inc.",
7+
"repository": {
8+
"type": "git",
9+
"url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
10+
},
11+
"cloud": {
12+
"requiresKeyFile": true,
13+
"requiresProjectId": true
14+
},
15+
"engines": {
16+
"node": ">=4.3.2"
17+
},
718
"scripts": {
8-
"test": "cd ..; npm run st -- --verbose dns/system-test/*.test.js"
19+
"lint": "samples lint",
20+
"pretest": "npm run lint",
21+
"system-test": "ava -T 1m --verbose system-test/*.test.js",
22+
"test": "npm run system-test"
923
},
1024
"dependencies": {
1125
"@google-cloud/dns": "0.5.0",
12-
"yargs": "6.6.0"
26+
"yargs": "7.1.0"
1327
},
14-
"engines": {
15-
"node": ">=4.3.2"
28+
"devDependencies": {
29+
"@google-cloud/nodejs-repo-tools": "1.3.1",
30+
"ava": "0.19.1",
31+
"proxyquire": "1.7.11",
32+
"sinon": "2.1.0"
1633
}
1734
}

0 commit comments

Comments
 (0)