fix: make requests import conditional for gce universe domain #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
reviewed
Feb 15, 2024
arithmetic1728
approved these changes
Feb 15, 2024
sai-sunder-s
force-pushed
the
fiximportrequests
branch
from
7d3d36e to
345e50a
Compare
arithmetic1728
approved these changes
Feb 15, 2024
sai-sunder-s
force-pushed
the
fiximportrequests
branch
from
1a30132 to
96a01e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1433 a dependency for requests was introduced unconditionally i.e. requests lib was required for anyone use gce mds even if they are not using TPC. This PR makes the import conditional.