Skip to content

fix: Add Test to validate 0x20 in token #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 6 commits into from
Aug 11, 2022
Merged

fix: Add Test to validate 0x20 in token #971

gcf-merge-on-green merged 6 commits into from
Aug 11, 2022

Conversation

@sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Aug 9, 2022 •
edited by TimurSadykov
Loading

Adds a test for a reported condition where 0x20 character causes an exception

@sai-sunder-s sai-sunder-s requested a review from a team as a code owner August 9, 2022 20:05
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 9, 2022
TimurSadykov
TimurSadykov reviewed Aug 10, 2022
View reviewed changes
@sai-sunder-s sai-sunder-s changed the title fix: remove leading and trailing whitespace from idtoken fix: Add Test to validate 0x20 in token Aug 11, 2022
@sai-sunder-s sai-sunder-s added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
TimurSadykov
TimurSadykov approved these changes Aug 11, 2022
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimurSadykov TimurSadykov added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 612db0a into googleapis:main Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2022
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sai-sunder-s @TimurSadykov @kokoro-team