fix: unknown resources do not cause a generator crash #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some resource references do not map to actual known resource types,
e.g. from the Logging API
string destination = 3 [
(google.api.resource_reference) = {
type: "*"
}
];
It's easiest to just ignore invalid resource types.
software-dov
requested review from
arithmetic1728,
busunkim96,
crwilcox,
lukesneeringer and
vchudnov-g
google-cla
bot
added
the
cla: yes
busunkim96
approved these changes
Oct 20, 2020
software-dov
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1560 1561 +1
Branches 315 315
=========================================
+ Hits 1560 1561 +1
Continue to review full report at Codecov.
|
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [0.35.6](https://www.github.com/googleapis/gapic-generator-python/compare/v0.35.5...v0.35.6) (2020-10-20) ### Bug Fixes * unknown resources do not cause a generator crash ([#675](https://www.github.com/googleapis/gapic-generator-python/issues/675)) ([2d23d7d](https://www.github.com/googleapis/gapic-generator-python/commit/2d23d7d202099ccf145c01aeb9a03ae46b4e1b00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resource references do not map to actual known resource types,
e.g. from the Logging API
string destination = 3 [
(google.api.resource_reference) = {
type: "*"
}
];
It's easiest to just ignore invalid resource types.