fix: Fix client template type hints #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Contributor
Author
|
Will fix build errors due to aliasing name. |
Contributor
Author
fixed |
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1519 1519
Branches 309 309
=========================================
Hits 1519 1519 Continue to review full report at Codecov.
|
software-dov
approved these changes
Sep 14, 2020
Contributor
software-dov
left a comment
software-dov
left a comment
There was a problem hiding this comment.
LGTM. Could you please apply these changes to 'ads-templates/.../client.py.j2' as well?
Contributor
Author
Done. Should be ready to merge. |
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This template causes type errors because it declares the type of a parameter to be an imported file. Remove the confusion here, and also correctly annotate some possibly-None parameters.