fix: preserve hyperlinks with hyphens #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
force-pushed
the
preserve-links-with-hyphens
branch
from
4dfb8aa to
fff337f
Compare
busunkim96
reviewed
Jan 20, 2022
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
Nice find! Could you add a unit test that checks a string with a hyperlink?
parthea
force-pushed
the
preserve-links-with-hyphens
branch
from
c4b6966 to
e7f4477
Compare
parthea
force-pushed
the
preserve-links-with-hyphens
branch
from
e7f4477 to
2947aa6
Compare
Contributor
Author
|
@busunkim96 @software-dov Please could you review/approve? |
software-dov
approved these changes
Jan 25, 2022
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of
textwrap.wrapis to break text on hyphens. This PR sets thebreak_on_hyphensparameter oftextwrap.wraptoFalsein order to preserve hyperlinks with hyphens.Fixes #1131