Skip to content

fix: don't enable snippetgen by default #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vam-google merged 2 commits into from
Nov 8, 2021
Merged

fix: don't enable snippetgen by default #1078

vam-google merged 2 commits into from
Nov 8, 2021

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Nov 8, 2021 •
edited
Loading

Reverts #1055 and #1044 to unblock updating the gapic-generator-python version in googleapis.

Merge if #1077 does not resolve broken generation for all APIs.

@busunkim96 busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2021
@busunkim96 busunkim96 requested review from a team as code owners November 8, 2021 18:15
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2021
@busunkim96 busunkim96 requested a review from vam-google November 8, 2021 18:19
@vam-google
Copy link
Contributor

vam-google commented Nov 8, 2021

@busunkim96 It still fails with

 File "/bazel_root/e042807395a19eea202a942734de1338/sandbox/processwrapper-sandbox/5590/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/samplegen/samplegen.py", line 536, in validate_and_transform_request
    raise types.BadAttributeLookup(
gapic.samplegen_utils.types.BadAttributeLookup: Method request type MessageType(message_pb=name: "UpdatePrivateCloudRequest"

At least in //google/cloud/vmwareengine/v1:vmwareengine_py_gapic API, so I believe we need to push this

@vam-google vam-google removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2021
@vam-google vam-google merged commit 8bdb709 into master Nov 8, 2021
@vam-google vam-google deleted the revert-snippetgen-default branch November 8, 2021 18:43
busunkim96 added a commit that referenced this pull request Nov 16, 2021
@busunkim96
Revert "fix: don't enable snippetgen by default (#1078)"
afbc8c6 
This reverts commit 8bdb709.
This was referenced Jan 18, 2022
Merged
Closed
busunkim96 added a commit that referenced this pull request Jan 20, 2022
@busunkim96
Revert "fix: don't enable snippetgen by default (#1078)"
469024f 
This reverts commit 8bdb709.
This was referenced Jan 21, 2022
Closed
Closed
Closed
Merged
busunkim96 added a commit that referenced this pull request Jan 28, 2022
@busunkim96
Revert "fix: don't enable snippetgen by default (#1078)"
02e5331 
This reverts commit 8bdb709.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vam-google vam-google Awaiting requested review from vam-google

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@busunkim96 @vam-google @tseaver