Skip to content

Commit da2ff71

Browse files
authored
fix: exclude 'input' from reserved names list (#788)
The motivation for this is to prevent a breaking change in a library that has already been made GA: texttospeech googleapis/python-texttospeech#99. The TTS protos have a field named [`input`](https://github.com/googleapis/googleapis/blob/eabe7c0fde64b1451df6ea171b2009238b0df07c/google/cloud/texttospeech/v1/cloud_tts.proto#L134-L143). Dialogflow CX beta appears to also have a field named `input`, but those changes have not yet been published and it is a pre-GA API. https://github.com/search?l=Python&p=1&q=org%3Agoogleapis+input_&type=Code
1 parent 2e17ede commit da2ff71

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gapic/utils/reserved_names.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@
2222
RESERVED_NAMES = frozenset(
2323
itertools.chain(
2424
keyword.kwlist,
25-
set(dir(builtins)) - {"filter", "map", "id", "property"},
25+
set(dir(builtins)) - {"filter", "map", "id", "input", "property"},
2626
)
2727
)

0 commit comments

Comments
 (0)