Upgrade to Gradle 5.2 and Error Prone 2.10.0. (#155)

I would like to be able to support RE2J building under JDK11. Also, we
need to move to Sonatype Nexus publishing after the shutdown of JCenter,
and that tooling requires a later version of Gradle.

Author: sjamesr

build.gradle

@@ -5,7 +5,7 @@ plugins {
   id 'com.jfrog.bintray' version '1.8.1'
   id 'maven-publish'
   id 'com.github.sherter.google-java-format' version '0.3.2'
-  id 'net.ltgt.errorprone' version '0.0.11'
+  id 'net.ltgt.errorprone' version '2.0.2'
   id 'idea'
 
   // code coverage support
@@ -25,7 +25,7 @@ cobertura.coverageFormats = ['html', 'xml']
 def versionName = '1.6'
 
 wrapper {
-  gradleVersion '4.9'
+  gradleVersion '5.2'
 }
 
 sourceCompatibility = 1.6
@@ -79,6 +79,9 @@ test {
 }
 
 dependencies {
+  errorproneJavac 'com.google.errorprone:javac:9+181-r4173-1'
+  errorprone 'com.google.errorprone:error_prone_core:2.10.0'
+
   testCompile 'junit:junit:4.12'
   testCompile 'com.google.gwt:gwt-dev:2.9.0'
   testCompile 'com.google.gwt:gwt-user:2.9.0'
@@ -88,12 +91,6 @@ dependencies {
   testRuntime "org.slf4j:slf4j-api:1.7.10"
 }
 
-// Use error_prone_core 2.0.5, later versions require Java 8 to build and we'd
-// like to support building on Java 7.
-configurations.errorprone {
-  resolutionStrategy.force 'com.google.errorprone:error_prone_core:2.0.5'
-}
-
 task sourceJar(type: Jar) {
     baseName 'sources'
 

gradle/wrapper/gradle-wrapper.jar

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.9-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-5.2-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

gradle/wrapper/gradle-wrapper.properties

@@ -28,7 +28,7 @@ APP_NAME="Gradle"
 APP_BASE_NAME=`basename "$0"`
 
 # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-DEFAULT_JVM_OPTS=""
+DEFAULT_JVM_OPTS='"-Xmx64m"'
 
 # Use the maximum available, or set MAX_FD != -1 to use that value.
 MAX_FD="maximum"

gradlew

@@ -14,7 +14,7 @@ set APP_BASE_NAME=%~n0
 set APP_HOME=%DIRNAME%
 
 @rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-set DEFAULT_JVM_OPTS=
+set DEFAULT_JVM_OPTS="-Xmx64m"
 
 @rem Find java.exe
 if defined JAVA_HOME goto findJavaFromJavaHome

gradlew.bat

@@ -160,15 +160,14 @@ public void testAppendClass() {
 
   @Test
   public void testAppendFoldedClass() {
-    // NB, local variable names use Unicode.
     // 0x17F is an old English long s (looks like an f) and folds to s.
     // 0x212A is the Kelvin symbol and folds to k.
-    char ſ = 0x17F, K = 0x212A;
+    char s = 0x17F, k = 0x212A;
 
-    assertClass(cc().appendFoldedClass(i('a', 'z')), s("akAK" + K + K + "lsLS" + ſ + ſ + "tzTZ"));
+    assertClass(cc().appendFoldedClass(i('a', 'z')), s("akAK" + k + k + "lsLS" + s + s + "tzTZ"));
 
     assertClass(
-        cc('a', 'f').appendFoldedClass(i('c', 't')), s("akCK" + K + K + "lsLS" + ſ + ſ + "ttTT"));
+        cc('a', 'f').appendFoldedClass(i('c', 't')), s("akCK" + k + k + "lsLS" + s + s + "ttTT"));
 
     assertClass(cc('c', 't').appendFoldedClass(i('a', 'f')), 'c', 't', 'a', 'f', 'A', 'F');
   }

javatests/com/google/re2j/CharClassTest.java

@@ -482,7 +482,9 @@ private void testSubmatchBytes(String testName, FindTest.Test test, int n, byte[
     for (int k = 0; k < GoTestUtils.len(result); k++) {
       if (submatches[k * 2] == -1) {
         if (result[k] != null) {
-          fail(String.format("%s %d: expected null got %s: %s", testName, n, result, test));
+          fail(
+              String.format(
+                  "%s %d: expected null got %s: %s", testName, n, Arrays.toString(result), test));
         }
         continue;
       }