Remove type check function for repeated fields #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szakarias
force-pushed
the
redundantTypeCheck
branch
from
49fb4d0 to
e6a1ce8
Compare
sigurdm
approved these changes
Feb 11, 2019
| } | ||
|
|
||
| // Deprecated, use [pc] instead. | ||
| @deprecated |
There was a problem hiding this comment.
I think there is a deprecated constructor that takes the description as an argument https://api.dartlang.org/stable/2.1.0/dart-core/Deprecated-class.html
There was a problem hiding this comment.
You can also mention in the docstring that the check is ignored.
| @@ -67,7 +67,7 @@ class PbFieldType { | |||
|
|
|||
| // Closures commonly used by initializers. | |||
| static String _STRING_EMPTY() => ''; | |||
| static List<int> _BYTES_EMPTY() => new PbList<int>(check: _checkInt); | |||
| static List<int> _BYTES_EMPTY() => new PbList<int>(); | |||
There was a problem hiding this comment.
I think this should never have been a pblist.
| @@ -48,6 +48,7 @@ class PbList<E> extends PbListBase<E> { | |||
|
|
|||
| PbList.from(List from) : super._from(from); | |||
|
|
|||
| @deprecated | |||
There was a problem hiding this comment.
Also here add explanation
|
cc @mkustermann this removes one of the closures from GeneratedMessage instances. |
szakarias
force-pushed
the
redundantTypeCheck
branch
from
13266ae to
ccb7b5e
Compare
|
PTAL |
sigurdm
reviewed
Feb 18, 2019
| @@ -325,12 +325,4 @@ abstract class PbListBase<E> extends ListBase<E> { | |||
| } | |||
| _wrappedList.length = newLength; | |||
| } | |||
|
|
|||
| void _validate(E val) { | |||
sigurdm
reviewed
Feb 18, 2019
| } else if (type.isEnum) { | ||
| out.println(', $_protobufImportPrefix.checkNotNull, null, ' |
There was a problem hiding this comment.
remember to make checkNotNull private again.
sigurdm
reviewed
Feb 18, 2019
protoc_plugin/pubspec.yaml
Outdated
| @@ -10,7 +10,7 @@ environment: | |||
| dependencies: | |||
| fixnum: ^0.10.5 | |||
| path: ^1.0.0 | |||
| protobuf: ^0.13.2 | |||
| protobuf: ^0.13.3 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201