Skip to content

Refactor the test goldens so they have standard file name extensions #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactor the test goldens so they have standard file name extensions #1014

wants to merge 6 commits into from

Conversation

devoncarew
Copy link
Collaborator

@devoncarew devoncarew commented May 28, 2025 •
edited
Loading

Refactor the test goldens so they have standard file name extensions:

Done as a few separate commits for easier review.

@devoncarew devoncarew changed the title Refactor our test goldens so they have std file name extensions Refactor the test goldens so they have standard file name extensions May 29, 2025
@devoncarew devoncarew requested a review from osa1 May 30, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osa1 osa1 Awaiting requested review from osa1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider having our golden testing files use correct file name extensions
1 participant
@devoncarew