Skip to content

consider having our golden testing files use correct file name extensions #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
devoncarew opened this issue May 23, 2025 · 0 comments · May be fixed by #1014
Open

consider having our golden testing files use correct file name extensions #1008

devoncarew opened this issue May 23, 2025 · 0 comments · May be fixed by #1014
Labels
testing

Comments

@devoncarew
Copy link
Collaborator

We should consider having our golden testing files use correct file name extensions. Currently they have their file extensions stripped off which is odd to read (imports => imports.pb.dart; enum.pb => enum.pb.dart).

https://github.com/google/protobuf.dart/tree/master/protoc_plugin/test/goldens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor the test goldens so they have standard file name extensions devoncarew/protobuf.dart
1 participant
@devoncarew