Commit 0447bd2
authored
Run plugin with asserts when building test protos (#1055)
Currently we run the tests with assertions but that doesn't cover some of the
code paths.
When building the test protos we don't run the plugin with assertions.
Add a new executable `protoc-gen-dart-debug` that is the same as
`protoc-gen-dart`, but passes `--enable-asserts` to Dart. Use it when building
test protos.
This triggers an assertion which was reported in #608. The assertion is clearly
wrong (we call the function for repeated fields a few lines above the
assertion) and no one knows or remembers why it's there. Remove the assertion.
Closes #608.1 parent 660bbc8 commit 0447bd2
File tree
3 files changed
+4
-2
lines changed- protoc_plugin
- bin
- lib/src
3 files changed
+4
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
393 | 393 | | |
394 | 394 | | |
395 | 395 | | |
396 | | - | |
397 | 396 | | |
398 | 397 | | |
399 | 398 | | |
| |||
0 commit comments