Skip to content

Use controllersFile and similar constants #11729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use controllersFile and similar constants #11729

wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented May 15, 2025 •
edited
Loading

Just noticed constant is there but not used.

@stepancheg stepancheg marked this pull request as ready for review May 15, 2025 02:42
ayushr2
ayushr2 reviewed May 15, 2025
View reviewed changes
Copy link
Collaborator

@ayushr2 ayushr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, please also fix the other locations that are duplicating constant values:

  • Line 560 should use memoryLimitCgroup
  • Line 439 should use cpuLimitCgroup

@stepancheg
Copy link
Contributor Author

Done.

@stepancheg stepancheg changed the title Use controllersFile constant Use controllersFile and similar constants May 15, 2025
copybara-service bot pushed a commit that referenced this pull request May 15, 2025
@stepancheg @gvisor-bot
Use controllersFile and similar constants
5d22aec 
Just noticed constant is there but not used.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11729 from stepancheg:constant 1410b28
PiperOrigin-RevId: 759307431
@copybara-service copybara-service bot mentioned this pull request May 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushr2 ayushr2 ayushr2 approved these changes

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepancheg @ayushr2