Skip to content

Add Topics to PushEventRepository #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ecrupper opened this issue Apr 7, 2023 · 1 comment · Fixed by #2742
Closed

Add Topics to PushEventRepository #2741

ecrupper opened this issue Apr 7, 2023 · 1 comment · Fixed by #2742

Comments

@ecrupper
Copy link
Contributor

ecrupper commented Apr 7, 2023

I would like to leverage the topics field found in the repository object of several webhook event payloads. I noticed that for the push event, which has a special repo struct, the Topics field was missing.

I plan on implementing this enhancement the same way the standard repository struct does it, unless there are any objections. I am curious why it is of type []string and not *[]string though, if anyone would be willing to clarify that for me? It doesn't get an accessor generated as a result.

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 7, 2023

We typically only use a pointer to a slice when it is important in the GitHub v3 API to accurately distinguish between when the slice is provided and when it is not. Otherwise, we typically use just a slice since they are easier to deal with.

Yes, PRs to add missing fields are welcome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants