Skip to content

Commit c9c37fd

Browse files
committed
Don't require client_secret to be present.
Only test that secret is not included. It seems versions of Go 1.6 and older did not include the URL query parameters.
1 parent beac0e8 commit c9c37fd

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

github/github_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,7 @@ func TestDo_sanitizeURL(t *testing.T) {
392392
if err == nil {
393393
t.Fatal("Expected error to be returned.")
394394
}
395-
if !strings.Contains(err.Error(), "client_secret=REDACTED") ||
396-
strings.Contains(err.Error(), "client_secret=secret") {
395+
if strings.Contains(err.Error(), "client_secret=secret") {
397396
t.Errorf("Do error contains secret, should be redacted:\n%q", err)
398397
}
399398
}

0 commit comments

Comments
 (0)