Skip to content

Commit ee6f7a4

Browse files
committed
Minor improvements and move GIDEMMSupportTest to a separate PR.
1 parent 70bc182 commit ee6f7a4

File tree

3 files changed

+1
-222
lines changed

3 files changed

+1
-222
lines changed

GoogleSignIn/Tests/Unit/GIDEMMSupportTest.m

Lines changed: 0 additions & 210 deletions
This file was deleted.

GoogleSignIn/Tests/Unit/GIDGoogleUserTest.m

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ - (void)tearDown {
8181
[GULSwizzler unswizzleClass:[OIDAuthorizationService class]
8282
selector:@selector(performTokenRequest:originalAuthorizationResponse:callback:)
8383
isClassSelector:YES];
84-
8584
}
8685

8786
#pragma mark - Tests
@@ -236,8 +235,6 @@ - (void)testDoWithFreshTokens_refresh_givenBothTokensExpired {
236235

237236
_tokenFetchHandler(fakeResponse, nil);
238237
[self waitForExpectationsWithTimeout:1 handler:nil];
239-
240-
241238
}
242239

243240
- (void)testDoWithRefreshTokens_refresh_givenBothTokensExpired_NoNewIDToken {
@@ -265,8 +262,6 @@ - (void)testDoWithRefreshTokens_refresh_givenBothTokensExpired_NoNewIDToken {
265262

266263
_tokenFetchHandler(fakeResponse, nil);
267264
[self waitForExpectationsWithTimeout:1 handler:nil];
268-
269-
270265
}
271266

272267
- (void)testDoWithFreshTokens_refresh_givenAccessTokenExpired {
@@ -327,7 +322,7 @@ - (void)testDoWithFreshTokens_refresh_givenIDTokenExpired {
327322
[self waitForExpectationsWithTimeout:1 handler:nil];
328323
}
329324

330-
- (void)testDoWithFreshTokens_noRefreh_givenBothNotExpire {
325+
- (void)testDoWithFreshTokens_noRefresh_givenBothTokensNotExpired {
331326
// Both tokens will expire in 10 min.
332327
NSTimeInterval expiresIn = 10 * 60;
333328
GIDGoogleUser *user = [self googleUserWithAccessTokenExpiresIn:expiresIn

GoogleSignIn/Tests/Unit/GIDSignInTest.m

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,6 @@ @interface GIDSignInTest : XCTestCase {
207207
// Mock for |GIDGoogleUser|.
208208
id _user;
209209

210-
// Mock for |GIDAuthentication|.
211-
id _authentication;
212-
213210
// Mock for |OIDAuthorizationService|
214211
id _oidAuthorizationService;
215212

@@ -367,7 +364,6 @@ - (void)tearDown {
367364
OCMVerifyAll(_tokenRequest);
368365
OCMVerifyAll(_authorization);
369366
OCMVerifyAll(_user);
370-
OCMVerifyAll(_authentication);
371367
OCMVerifyAll(_oidAuthorizationService);
372368

373369
#if TARGET_OS_IOS || TARGET_OS_MACCATALYST
@@ -417,8 +413,6 @@ - (void)testRestorePreviousSignInNoRefresh_hasPreviousUser {
417413
OCMStub([_tokenResponse accessToken]).andReturn(kAccessToken);
418414
OCMStub([_tokenResponse accessTokenExpirationDate]).andReturn(nil);
419415

420-
421-
422416
[_signIn restorePreviousSignInNoRefresh];
423417

424418
[_authorization verify];

0 commit comments

Comments
 (0)