Improve testing class GIDGoogleUserOldFormat

Author: Alex-4-Git

GoogleSignIn/Sources/GIDAuthentication.m

@@ -31,7 +31,7 @@ @implementation GIDAuthentication
 - (instancetype)initWithAuthState:(OIDAuthState *)authState {
   self = [super init];
   if (self) {
-    self.authState = authState;
+    _authState = authState;
   }
   return self;
 }
@@ -45,7 +45,7 @@ + (BOOL)supportsSecureCoding {
 - (nullable instancetype)initWithCoder:(NSCoder *)decoder {
   self = [super init];
   if (self) {
-    self.authState = [decoder decodeObjectOfClass:[OIDAuthState class] forKey:kAuthStateKey];
+    _authState = [decoder decodeObjectOfClass:[OIDAuthState class] forKey:kAuthStateKey];
   }
   return self;
 }

GoogleSignIn/Sources/GIDGoogleUser.m

@@ -222,7 +222,7 @@ - (void)updateWithTokenResponse:(OIDTokenResponse *)tokenResponse
 
     // We don't want to trigger the delegate before we update authState completely. So we unset the
     // delegate before the first update. Also the order of updates is important because
-    // `updateWithAuthorizationResponse` would clears the last token reponse and refresh token.
+    // `updateWithAuthorizationResponse` would clear the last token reponse and refresh token.
     self.authState.stateChangeDelegate = nil;
     [self.authState updateWithAuthorizationResponse:authorizationResponse error:nil];
     self.authState.stateChangeDelegate = self;

GoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.h

@@ -24,11 +24,11 @@
 
 @end
 
-// The old format GIDGoogleUser containing a GIDAuthentication.
+// The old format GIDGoogleUser contains a GIDAuthentication.
 // Note: remove this class when GIDGoogleUser no longer support old encoding.
 @interface GIDGoogleUserOldFormat : GIDGoogleUser
 
-- (instancetype)initOldGIDGoogleUserWithAuthState:(OIDAuthState *)authState
-                                      profileData:(GIDProfileData *)profileData;
+- (instancetype)initWithAuthState:(OIDAuthState *)authState
+                      profileData:(GIDProfileData *)profileData;
 
 @end

GoogleSignIn/Tests/Unit/GIDGoogleUser+Testing.m

@@ -61,8 +61,8 @@ @implementation GIDGoogleUserOldFormat {
   GIDProfileData *_profile;
 }
 
-- (instancetype)initOldGIDGoogleUserWithAuthState:(OIDAuthState *)authState
-                                      profileData:(GIDProfileData *)profileData {
+- (instancetype)initWithAuthState:(OIDAuthState *)authState
+                      profileData:(GIDProfileData *)profileData {
   self = [super initWithAuthState:authState profileData:profileData];
   if (self) {
     _authentication = [[GIDAuthentication alloc] initWithAuthState:authState];

GoogleSignIn/Tests/Unit/GIDGoogleUserTest.m

@@ -138,9 +138,8 @@ - (void)testOldFormatCoding {
   if (@available(iOS 11, macOS 10.13, *)) {
     OIDAuthState *authState = [OIDAuthState testInstance];
     GIDProfileData *profileDate = [GIDProfileData testInstance];
-    GIDGoogleUserOldFormat *user =
-        [[GIDGoogleUserOldFormat alloc] initOldGIDGoogleUserWithAuthState:authState
-                                                              profileData:profileDate];
+    GIDGoogleUserOldFormat *user = [[GIDGoogleUserOldFormat alloc] initWithAuthState:authState
+                                                                         profileData:profileDate];
     NSData *data = [NSKeyedArchiver archivedDataWithRootObject:user
                                          requiringSecureCoding:YES
                                                          error:nil];