-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Feat/651 Outfit Assistant Notebook #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/651 Outfit Assistant Notebook #658
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Can anyone review this? |
06c1cb9
to
5ebe25e
Compare
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:49Z Line #1. %pip install -U -q "google-genai" # Install the Python SDK Can you add a minimum version, like
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:50Z Ideally we should distribute the imports in the cells where they are needed. |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:51Z What about using search grounding instead and ask Gemini to check the weather? |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:52Z Line #1. def get_weather(city: str, country: str = "") -> str: I wouldn't mix helper function and a function that is meant to be used with function calling.
As for the helper functions, they should have a |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:53Z I think it needs a better title, right now it feel like a bit like an AI generated explanatory comment. Maybe just a setup section and a get advices one? |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:54Z Where does the images comes from? What's their license? Do we have the rights to use them? |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:55Z I would group this and the next two sections into one, with texts instead of titles. |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:56Z I think you need to explain a bit more what are the different steps, what are the user preferences and how you build your prompt. |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:57Z Line #15. country = input("🌍 Enter your country to fetch the weather (or press Enter to skip): ").strip() You shouldn't ask for a country if no city was provided I think. |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:58Z Line #22. elif not WEATHER_API: I think you should do the check before asking for the location and the country |
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:55:59Z Line #69. model='gemini-2.0-flash', Can you add a "MODEL_ID" variable like this?
As it would make the notebook easier to maintain in the future.
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2025-04-23T13:56:00Z Why did you added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GurneeshBudhiraja for the submission and sorry for the delayed review.
I just added a couple of minor comments to make the notebook easier to understand and to maintain.
@@ -79,6 +79,7 @@ Then, explore the other quickstarts tutorials to learn about individual features | |||
## 2. Examples (Practical Use Cases) | |||
|
|||
These examples demonstrate how to combine multiple Gemini API features or 3rd-party tools to build more complex applications. | |||
* [Outfit Assistant](./examples/Outfit_Assistant.ipynb): Leverages Gemini's multimodality to get outfit recommendations based on the user's preferences, occasion, and temperature of the user's location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I'm trying to keep only Google-made examples on the main README, but you should definitely add a link to yours in the examples/README.md
Do you still want to push this @GurneeshBudhiraja? |
I am not sure if I would be able to complete this. You can close the PR or take it from here. |
Feature id: #651
Jupyter notebook implementation of outfit assistant using Gemini 2.0 flash model.
Thank you and looking forward to the feedback. 😃