Skip to content

Fix paths for windows users #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix paths for windows users #5

wants to merge 1 commit into from

Conversation

EugeneAndrosovPaser
Copy link

Fix path for windows users.

@lhyqy5 lhyqy5 mentioned this pull request Sep 6, 2021
Closed
3 tasks
@ldez ldez added the bug Something isn't working label Jul 8, 2022
@de1acr0ix
Copy link

Regarding the impacts of this change, filepath.ToSlash() converts the path separators to forward slashes. So the only possible regression is that c.changes contains path(s) with path separators which are not forward slashes. Those actually come from git diff command or patch file, in which I believe should always be forward slashes.

@ldez
Copy link
Member

ldez commented Aug 3, 2022

the fix contained in this PR has been integrated into the following commit 731d42a

@ldez ldez closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EugeneAndrosovPaser @de1acr0ix @ldez