Skip to content

Remove reference to golangci.com in README #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020
Merged

Remove reference to golangci.com in README #997

merged 1 commit into from
May 5, 2020

Conversation

evalexpr
Copy link
Contributor

This project is shutting down on the 15th April. See the blog below:
https://medium.com/golangci/golangci-com-is-closing-d1fc1bd30e0e

This project is shutting down on the 15th April. See the blog below:
https://medium.com/golangci/golangci-com-is-closing-d1fc1bd30e0e
@CLAassistant
Copy link

CLAassistant commented Mar 16, 2020

CLA assistant check
All committers have signed the CLA.

@lopezator
Copy link
Contributor

Thank you for this, we ❤️ doc contributions.

Apart from the changes proposed here there a more mentions in the README like the golangci.com configuration, for example.

This possibly also will need some change changes.

@jirfag do you prefer to do all at once, or are you ok with merging this and continue the remaining needed changes in future PRs?

@lopezator lopezator requested a review from jirfag March 30, 2020 11:58
@evalexpr
Copy link
Contributor Author

I’m happy to make further changes if we want to remove everything in one PR. I’ll grep for the obvious stuff tomorrow and see if it’s easily removable.

@ernado ernado added the blocked Need's direct action from maintainer label Apr 22, 2020
@ernado
Copy link
Member

ernado commented Apr 27, 2020

Now we have a https://github.com/golangci/golangci-lint-action which is doing pretty similar what golangci did.

Probably we can promote this method as alternative.

@ernado ernado removed the blocked Need's direct action from maintainer label Apr 27, 2020
@ernado ernado removed the request for review from jirfag April 27, 2020 22:16
@jirfag
Copy link
Contributor

jirfag commented May 5, 2020

thank you,
I'm ok to remove it iteratively. In 1-2 weeks I would like to promote our GitHub action in README.

@jirfag jirfag merged commit ca04ca6 into golangci:master May 5, 2020
@ldez ldez added this to the v1.27 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants