dev: run all commands on the CI #4526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area: tests
Antonboom
approved these changes
Mar 18, 2024
| @@ -130,3 +130,44 @@ jobs: | |||
| env: | |||
| # needed for github-action-config.json generation | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
|
|
|||
| # Note: the command `run` is tested by the previous steps (`make test`). | |||
| commands: | |||
There was a problem hiding this comment.
how to not forget to update this :D
maybe we need bash magic like
- run
golangci-lint 42 - parse
Available Commands: - loop: run command from 2, parse
Available Commandsagain - etc
But, of course, explicit is better than implicit 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs all golangci-lint commands.
The command
runis tested by the other steps (make test).To avoid problem similar to #3567