Allocate memory for known size slices #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
suggested changes
May 30, 2018
There was a problem hiding this comment.
@dixonwille thank you for pull request!
Also I'm planning to integrate https://github.com/alexkohler/prealloc to golangci-lint
pkg/golinters/gocyclo.go
Outdated
| @@ -22,17 +22,20 @@ func (Gocyclo) Desc() string { | |||
| func (g Gocyclo) Run(ctx context.Context, lintCtx *Context) ([]result.Issue, error) { | |||
| var stats []gocycloAPI.Stat | |||
| for _, f := range lintCtx.ASTCache.GetAllValidFiles() { | |||
| stats = gocycloAPI.BuildStats(f.F, f.Fset, stats) | |||
| stats = append(stats, gocycloAPI.BuildStats(f.F, f.Fset, stats)...) | |||
There was a problem hiding this comment.
gocycloAPI.BuildStats has the counter-intuitive signature, but inside it already appends:
func BuildStats(f *ast.File, fset *token.FileSet, stats []Stat) []Stat {
for _, decl := range f.Decls {
if fn, ok := decl.(*ast.FuncDecl); ok {
stats = append(stats, Stat{
PkgName: f.Name.Name,
FuncName: funcName(fn),
Complexity: complexity(fn),
Pos: fset.Position(fn.Pos()),
})
}
}
return stats
}There was a problem hiding this comment.
Good catch. That is very counter-intuitive. Thanks
| for _, s := range stats { | ||
| if s.Complexity <= lintCtx.Settings().Gocyclo.MinComplexity { | ||
| continue | ||
| break //Break as the stats is already sorted from greatest to least |
as BuildStats already appends
golangci
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this does not save that many memory allocations compared to other areas but every little bit helps in my opinion.
Also, think I fixed a bug that was not reported in GoCyclo on line 25. It was iterating through the files but only kept the latest stats instead of appending.