Skip to content

Dockerfile: move binary to /bin/ #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2019
Merged

Dockerfile: move binary to /bin/ #396

merged 1 commit into from
Feb 17, 2019

Conversation

fsouza
Copy link
Contributor

@fsouza fsouza commented Feb 15, 2019 •
edited
Loading

This addresses #393.

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fsouza fsouza changed the title Dockerfile: move binary to /bin/ and use alpine as base image Dockerfile: move binary to /bin/ Feb 15, 2019
AnikHasibul
AnikHasibul reviewed Feb 17, 2019
View reviewed changes
Copy link

@AnikHasibul AnikHasibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be in /usr/bin?

@jirfag jirfag merged commit f7d2e92 into golangci:master Feb 17, 2019
jirfag added a commit that referenced this pull request Feb 17, 2019
@jirfag
docker: install golangci-lint into /usr/bin
25a630d 
Relates #396
@jirfag
Copy link
Contributor

jirfag commented Feb 17, 2019

@fsouza thank you!
@AnikHasibul thank you for suggestion I've fixed it and placed binary in /usr/bin

@tpounds tpounds mentioned this pull request Oct 1, 2019
Closed
@ldez ldez added this to the v1.15 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnikHasibul AnikHasibul AnikHasibul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
5 participants
@fsouza @CLAassistant @jirfag @AnikHasibul @ldez