Skip to content

Add support for generating illumos/amd64 targeted builds #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

Add support for generating illumos/amd64 targeted builds #3907

merged 1 commit into from
Jun 14, 2023

Conversation

szaydel
Copy link
Contributor

@szaydel szaydel commented Jun 14, 2023 •
edited by ldez
Loading

This is related to issue #3849. I believe this is all that's necessary to add support for building illumos/amd64 releases. Please provide any feedback if something feels incomplete.

related to #1910

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 14, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ldez
Copy link
Member

ldez commented Jun 14, 2023 •
edited
Loading

@szaydel I don't have a way to test your PR so I will just ask you if tested the script.

@ldez ldez added enhancement New feature or improvement area: install Issue relates to installation or downloading process labels Jun 14, 2023
@ldez ldez self-requested a review June 14, 2023 20:35
@szaydel
Copy link
Contributor Author

szaydel commented Jun 14, 2023

@ldez , I believe this is working as expected. Here's what I am seeing:

omni@omni-lab:/build/development/golangci-lint$ bash install.sh ; echo $?
golangci/golangci-lint info checking GitHub for latest tag
golangci/golangci-lint info found version: 1.53.2 for v1.53.2/illumos/amd64
1

But, I am assuming that this is failing simply because there's no release available yet.

ldez
ldez approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@szaydel
Copy link
Contributor Author

szaydel commented Jun 14, 2023

Thank you very much for accepting the PR. Cheers!

@ldez ldez merged commit 2dcd82f into golangci:master Jun 14, 2023
@ldez ldez added this to the v1.53 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: install Issue relates to installation or downloading process enhancement New feature or improvement
Projects
None yet
Milestone
v1.53
Development

Successfully merging this pull request may close these issues.
3 participants
@szaydel @CLAassistant @ldez