Explicitly pass GITHUB_TOKEN env to goreleaser action #1215
Conversation
|
Hey, thank you for opening your first Pull Request ! |
|
|
| @@ -23,3 +23,5 @@ jobs: | |||
| uses: goreleaser/goreleaser-action@v1 | |||
| with: | |||
| args: release --rm-dist | |||
| env: | |||
There was a problem hiding this comment.
💯
Just curious on how to re-run, or one more release is required.
There was a problem hiding this comment.
Actually it's impossible to re run this action because it triggers on a tag event:
on:
push:
tags:
- v*
You can re-run failed actions, but they will use an old code.
Only one way to avoid a new release is run goreleaser manually
There was a problem hiding this comment.
seems like only brew release was failing, I think we can re-run manually for brew only. /cc @golangci/team @golangci/core-team
| args: release --rm-dist | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GOLANGCI_LINT_TOKEN }} |
There was a problem hiding this comment.
nits we can refer to env define in job level as well, something like ${{ env.GITHUB_TOKEN }}, but I think it's fine to use secrets.GOLANGCI_LINT_TOKEN here :)
|
Hey, @SVilgelm — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
|
@sayboras @golangci/team @golangci/core-team |
|
Thanks for your reminder. I just push new tag v1.28.2 to kick off the new release again. Sadly, it's still failing https://github.com/golangci/golangci-lint/runs/856010530?check_suite_focus=true. Might need to wait for @golangci/core-team to help to verify GITHUB_TOKEN |
|
yeah, I see, I checked the |
|
@golangci/core-team Could you check please that the |
Fix a failing release workflow