Fix CodeClimate formater panic #1078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pkg/golinters/unused.go:NewUnused() set 'LineRange.To' equal to LineRange.From when the end position returned by u.ProblemObject(..) is not valid. When using 'code-climate' as formatter `golangci-lint` will panic with "index out of range [0] with length 0". This is caused because DisplayPosition(..)[1] from honnef.co/go/tools will return a zeroed token.Position struct if the given token position does not contain any line information. There should not be any side effects by setting 'LineRange.To' equal to 'From' since the 'unused' linter (mostly) only "targets" ONE line and not many. But even if 'unused' targets multiple lines there should be no issues because the returned "End" position will then be set to a correct value. [1]: https://github.com/dominikh/go-tools/blob/v0.0.1-2020.1.3/unused/unused.go#L496 Fixes: golangci#979 Signed-off-by: Francesco Emanuel Bennici <[email protected]>
|
|
3 tasks
|
thank you, |
|
We can't use this fix as is, because it breaks current workaround for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pkg/golinters/unused.go:NewUnused() set 'LineRange.To' equal to
LineRange.From when the the end position returned by u.ProblemObject(..)
is not valid.
When using 'code-climate' as formatter
golangci-lintwill panic with"index out of range [0] with length 0".
This is caused because DisplayPosition(..) from honnef.co/go/tools
will return a zeroed token.Position struct if the given token
position does not contain any line information.
There should not be any side effects by setting 'LineRange.To' equal to
'From' since the 'unused' linter (mostly) only "targets" ONE line and
not many. But even if 'unused' targets multiple lines there should be no
issues because the returned "End" position will then be set to a correct
value.
Fixes #979