Inconsistent linting results compare with gometalinter

[lnshi]

I just migrated to this project because was told by gometalinter's owner that that project will be deprecated soon.

But as this issue's title indicates: some of my previous code linting issues reported by gometalinter are just silently gone with golangci-lint, like the issues reported by: ineffassign, megacheck, unparam , staticcheck, gosec and dupl.

My golangci-lint config file .golangci.yml:

run:
  deadline: 10m
  skip-files:
    - daemon/httpserving/tf/benchmarks/json_codec_benchmark_test.go

linters:
  disable-all: true
  enable:
    - deadcode
    - dupl
    - gosec
    - goconst
    - gofmt
    - goimports
    - golint
    - stylecheck
    - gosimple
    - interfacer
    - ineffassign
    - misspell
    - nakedret
    - structcheck
    - staticcheck
    - unconvert
    - unparam
    - varcheck
    - vet
    - vetshadow
    - typecheck
    - maligned
    - prealloc
    - scopelint
    - gocritic
    - errcheck
    - unused
    - gocyclo
    - depguard

issues:
  exclude:
    # gosec
    - "G401: Use of weak cryptographic primitive"
    # gosec
    - "G501: Blacklisted import `crypto/md5`: weak cryptographic primitive"
    # staticcheck
    - "SA1019: grpc.CallCustomCodec is deprecated: use ForceCodec instead."

[jirfag]

Hi!
Can you attach more information? Missing warnings or reproducing example would be helpful. Also, what version of golangci-lint and gometalinter did you use? What was the configuration or running command for gometalinter?

[carnott-snap]

For me SA1019 is failing because it is mapping v1 to google.golang.org/api/gmail/v1, not the imported google.golang.org/api/iam/v1:

go doc google.golang.org/api/iam/v1.Service

type Service struct {
    // ... all fields elided ...
}

func New(client *http.Client) (*Service, error)

go doc google.golang.org/api/gmail/v1.Service

type Service struct {
    // ... all fields elided ...
}

func New(client *http.Client) (*Service, error)
func NewService(ctx context.Context, opts ...option.ClientOption) (*Service, error)

main.go

package main
  
import iam "google.golang.org/api/iam/v1"

func main() {
        _, _ = iam.New(nil)
}

golangci-lint run

main.go:6:9: SA1019: iam.New is deprecated: please use NewService instead. To provide a custom HTTP client, use option.WithHTTPClient. If you are using google.golang.org/api/googleapis/transport.APIKey, use option.WithAPIKey with NewService instead.  (staticcheck)
        _, _ = iam.New(nil)

[jirfag]

@lnshi also, did you try to set exclude-use-default=false?
@carnott-snap how does it relate to the gometalinter? can you add more details?