depguard is enabled and fails on v1.53.0

[adamdecaf]

Welcome

• Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've included all information below (version, config, etc.).
• Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.). (https://golangci-lint.run/usage/linters/)

Description of the problem

Running v1.53.0 of golangci-lint seems to enable depguard and fails due to a config error.

Version of golangci-lint

$ golangci-lint --version

v1.53.0

Configuration file

Go environment

$ go version && go env

go version go1.20.4 darwin/amd64

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v

golangci/golangci-lint info checking GitHub for tag 'v1.53.0'
golangci/golangci-lint info found version: 1.53.0 for v1.53.0/darwin/amd64
golangci/golangci-lint info installed ./bin/golangci-lint
STARTING golangci-lint checks
ERRO [linter] depguard: create analyzer: couldn't expand $gostd: could not read GOROOT directory: open src: no such file or directory
must have an Allow and/or Deny package list 

Code example or link to a public repository

Updating golangci-lint to v1.53.0 in https://github.com/moov-io/infra/blob/master/go/lint-project.sh

CI run: https://github.com/moov-io/infra/actions/runs/5149020788/jobs/9271486191

[gandarez]

It's happening with latest version released v1.53.0.

[gandarez]

There's an open issue to track it but the maintainer hasn't replied yet OpenPeeDeeP/depguard#46

[adamdecaf]

Does the upgrade to v2 need to be reverted? #3795

[ldez]

The configuration has changed and it's expected.

#3727

We will not revert the upgrade.

[gandarez]

It bumped from v1.52.2 to v1.53.0 so no major change was implicitly made. It's breaking for everyone who was using previous version and you assumed that's expected?? How to fix it without reverting the upgrade?

note: I have no depguard enabled on my side.

[ldez]

It bumped from v1.52.2 to v1.53.0 so no major change was implicitly made

We follow semver but we cannot follow the major version of each linter, then changes inside linter configuration are not considered as breaking.

[ldez]

I will try to reproduce the problem locally and find a fix.

[ldez]

Can you provide the output of go env?

[jhheider]

It fails something as simple as a golangci-lint help linters in an empty directory, where this was a working behavior in the previous version:

https://github.com/teaxyz/pantry/actions/runs/5148610773/jobs/9271272674

[adamdecaf]

I don't have depguard enabled either.

[ldez]

I need a reproducible context, then I need information.

$ golangci-lint version

$ go env

$ cat .golangci.yml

And a public repo.