Skip to content

Panic sometimes when continue is outside a for loop #130

Closed
@alecthomas

Description

@alecthomas

This is with 1.7.2:

runtime/debug.Stack(0x1809b61, 0x11, 0xc444197c60)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/runtime/debug/stack.go:24 +0xa7
github.com/golangci/golangci-lint/pkg/lint.Runner.runLinterSafe.func1(0xc444199ba8, 0xc43a584000, 0xb, 0xb, 0x18c5260, 0xc439f06220)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/lint/runner.go:73 +0xbc
panic(0x171c9a0, 0x1cda4c0)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/runtime/panic.go:502 +0x229
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*branchStack).get(0xc43ade9378, 0x0, 0xc444197e90)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:508 +0x6d
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*builder).Visit(0xc43ade9320, 0x18bcd00, 0xc438260c40, 0x18b9a20, 0xc43ade9320)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:222 +0x15c3
go/ast.Walk(0x18b9a20, 0xc43ade9320, 0x18bcd00, 0xc438260c40)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:52 +0x66
go/ast.walkStmtList(0x18b9a20, 0xc43ade9320, 0xc438260ca0, 0x2, 0x2)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:32 +0x81
go/ast.Walk(0x18b9a20, 0xc43ade9320, 0x18bccc0, 0xc438ac69f0)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:224 +0x1b61
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*builder).walk(0xc43ade9320, 0x18bccc0, 0xc438ac69f0)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:118 +0x5a
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*builder).Visit(0xc43ade9320, 0x18bd2c0, 0xc439158900, 0x0, 0x0)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:135 +0x236f
go/ast.Walk(0x18b9a20, 0xc43ade9320, 0x18bd2c0, 0xc439158900)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:52 +0x66
go/ast.walkStmtList(0x18b9a20, 0xc43ade9320, 0xc438260ce0, 0x2, 0x2)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:32 +0x81
go/ast.Walk(0x18b9a20, 0xc43ade9320, 0x18bccc0, 0xc438ac6a80)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:224 +0x1b61
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*builder).walk(0xc43ade9320, 0x18bccc0, 0xc438ac6a80)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:118 +0x5a
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*builder).fun(0xc43ade9320, 0xc438260d20, 0xc438ac6a80)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:375 +0x1aa
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*builder).Visit(0xc43ade9320, 0x18bd140, 0xc438ac6ab0, 0x0, 0x0)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:126 +0xc84
go/ast.Walk(0x18b9a20, 0xc43ade9320, 0x18bd140, 0xc438ac6ab0)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:52 +0x66
go/ast.walkDeclList(0x18b9a20, 0xc43ade9320, 0xc43b200500, 0xa, 0x10)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:38 +0x81
go/ast.Walk(0x18b9a20, 0xc43ade9320, 0x18bd0c0, 0xc43b0f9880)
	/home/travis/.gimme/versions/go1.10.3.linux.amd64/src/go/ast/walk.go:353 +0x2650
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.(*builder).walk(0xc43ade9320, 0x18bd0c0, 0xc43b0f9880)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:118 +0x5a
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.checkPath(0xc42f061950, 0xe, 0xc4395f5880, 0xc43b155880, 0xf, 0x10, 0x0, 0x0, 0x0)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:75 +0xfa
github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign.Run(0xc43a7e9400, 0x22, 0x40, 0x22, 0x40, 0xc42df14ce0)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/vendor/github.com/golangci/ineffassign/ineffassign.go:27 +0x2b6
github.com/golangci/golangci-lint/pkg/golinters.Ineffassign.Run(0x18c2a00, 0xc4201682a0, 0xc43a768a80, 0x10106e8, 0xc443607980, 0xc4201705a0, 0x17f3eca, 0xc43b2f30e0)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/golinters/ineffassign.go:23 +0x77
github.com/golangci/golangci-lint/pkg/lint.Runner.runLinterSafe(0xc43a584000, 0xb, 0xb, 0x18c5260, 0xc439f06220, 0x18c2a00, 0xc4201682a0, 0xc43a26a0c0, 0x18c1bc0, 0x1d0c4a8, ...)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/lint/runner.go:79 +0x194
github.com/golangci/golangci-lint/pkg/lint.Runner.runWorker.func1()
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/lint/runner.go:111 +0xe9
github.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc43b036000, 0x17fa4ba, 0xb, 0xc443607e50)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/timeutils/stopwatch.go:75 +0x53
github.com/golangci/golangci-lint/pkg/lint.Runner.runWorker(0xc43a584000, 0xb, 0xb, 0x18c5260, 0xc439f06220, 0x18c2a00, 0xc4201682a0, 0xc43a26a0c0, 0xc43a26a300, 0xc43a26ab40, ...)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/lint/runner.go:110 +0x1e4
github.com/golangci/golangci-lint/pkg/lint.(*Runner).runWorkers.func1(0xc438b83970, 0xc43a0d0a20, 0x18c2a00, 0xc4201682a0, 0xc43a26a0c0, 0xc43a26a300, 0xc43a26ab40, 0xc43a17a000, 0x8, 0x8, ...)
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/lint/runner.go:165 +0x152
created by github.com/golangci/golangci-lint/pkg/lint.(*Runner).runWorkers
	/home/travis/gopath/src/github.com/golangci/golangci-lint/pkg/lint/runner.go:162 +0x1b8

The following code triggered it:

func (s *Syncer) pollType(typ entity.Type, poller entity.Poller) {
	entities, err := s.store.List(typ)
	if err != nil {
		s.log.Printf("Failed to retrieve entities of type %q: %s", typ, err)
		continue
	}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions