dev: clean up unused receivers with revive (#4599)

Author: alexandear

.golangci.yml

@@ -99,6 +99,7 @@ linters-settings:
       - name: unexported-return
         disabled: true
       - name: unused-parameter
+      - name: unused-receiver
 
 linters:
   disable-all: true

pkg/commands/cache.go

@@ -50,7 +50,7 @@ func newCacheCommand() *cacheCommand {
 	return c
 }
 
-func (c *cacheCommand) executeClean(_ *cobra.Command, _ []string) error {
+func (*cacheCommand) executeClean(_ *cobra.Command, _ []string) error {
 	cacheDir := cache.DefaultDir()
 
 	if err := os.RemoveAll(cacheDir); err != nil {
@@ -60,7 +60,7 @@ func (c *cacheCommand) executeClean(_ *cobra.Command, _ []string) error {
 	return nil
 }
 
-func (c *cacheCommand) executeStatus(_ *cobra.Command, _ []string) {
+func (*cacheCommand) executeStatus(_ *cobra.Command, _ []string) {
 	cacheDir := cache.DefaultDir()
 	_, _ = fmt.Fprintf(logutils.StdOut, "Dir: %s\n", cacheDir)
 

pkg/goanalysis/linter.go

@@ -102,7 +102,7 @@ func (lnt *Linter) allAnalyzerNames() []string {
 	return ret
 }
 
-func (lnt *Linter) configureAnalyzer(a *analysis.Analyzer, cfg map[string]any) error {
+func (*Linter) configureAnalyzer(a *analysis.Analyzer, cfg map[string]any) error {
 	for k, v := range cfg {
 		f := a.Flags.Lookup(k)
 		if f == nil {

pkg/goanalysis/metalinter.go

@@ -31,11 +31,11 @@ func (ml MetaLinter) Run(_ context.Context, lintCtx *linter.Context) ([]result.I
 	return runAnalyzers(ml, lintCtx)
 }
 
-func (ml MetaLinter) Name() string {
+func (MetaLinter) Name() string {
 	return "goanalysis_metalinter"
 }
 
-func (ml MetaLinter) Desc() string {
+func (MetaLinter) Desc() string {
 	return ""
 }
 
@@ -57,11 +57,11 @@ func (ml MetaLinter) getAnalyzers() []*analysis.Analyzer {
 	return allAnalyzers
 }
 
-func (ml MetaLinter) getName() string {
+func (MetaLinter) getName() string {
 	return "metalinter"
 }
 
-func (ml MetaLinter) useOriginalPackages() bool {
+func (MetaLinter) useOriginalPackages() bool {
 	return false // `unused` can't be run by this metalinter
 }
 

pkg/lint/lintersdb/builder_linter.go

@@ -16,7 +16,7 @@ func NewLinterBuilder() *LinterBuilder {
 
 // Build loads all the "internal" linters.
 // The configuration is use for the linter settings.
-func (b LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
+func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 	if cfg == nil {
 		return nil, nil
 	}

pkg/lint/lintersdb/validator.go

@@ -62,7 +62,7 @@ func (v Validator) validateLintersNames(cfg *config.Linters) error {
 	return nil
 }
 
-func (v Validator) validatePresets(cfg *config.Linters) error {
+func (Validator) validatePresets(cfg *config.Linters) error {
 	presets := AllPresets()
 
 	for _, p := range cfg.Presets {

pkg/lint/package.go

@@ -105,7 +105,7 @@ func (l *PackageLoader) loadPackages(ctx context.Context, loadMode packages.Load
 	return l.filterTestMainPackages(pkgs), nil
 }
 
-func (l *PackageLoader) parseLoadedPackagesErrors(pkgs []*packages.Package) error {
+func (*PackageLoader) parseLoadedPackagesErrors(pkgs []*packages.Package) error {
 	for _, pkg := range pkgs {
 		var errs []packages.Error
 		for _, err := range pkg.Errors {

pkg/result/processors/autogenerated_exclude.go

@@ -49,7 +49,7 @@ func (p *AutogeneratedExclude) Process(issues []result.Issue) ([]result.Issue, e
 	return filterIssuesErr(issues, p.shouldPassIssue)
 }
 
-func (p *AutogeneratedExclude) Finish() {}
+func (*AutogeneratedExclude) Finish() {}
 
 func (p *AutogeneratedExclude) shouldPassIssue(issue *result.Issue) (bool, error) {
 	if issue.FromLinter == "typecheck" {

pkg/result/processors/path_prettifier.go

@@ -27,7 +27,7 @@ func (PathPrettifier) Name() string {
 	return "path_prettifier"
 }
 
-func (p PathPrettifier) Process(issues []result.Issue) ([]result.Issue, error) {
+func (PathPrettifier) Process(issues []result.Issue) ([]result.Issue, error) {
 	return transformIssues(issues, func(issue *result.Issue) *result.Issue {
 		if !filepath.IsAbs(issue.FilePath()) {
 			return issue