fix: linting

Author: ldez

.golangci.yml

@@ -10,7 +10,7 @@ linters-settings:
   dupl:
     threshold: 100
   funlen:
-    lines: 100
+    lines: -1 # the number of lines (code + empty lines) is not a right metric and leads to code without empty line or one-liner.
     statements: 50
   goconst:
     min-len: 2

pkg/golinters/nolintlint/nolintlint_test.go

@@ -11,7 +11,6 @@ import (
 	"github.com/golangci/golangci-lint/pkg/result"
 )
 
-//nolint:funlen
 func TestLinter_Run(t *testing.T) {
 	type issueWithReplacement struct {
 		issue       string

pkg/lint/lintersdb/enabled_set_test.go

@@ -10,7 +10,6 @@ import (
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
 )
 
-//nolint:funlen
 func TestGetEnabledLintersSet(t *testing.T) {
 	type cs struct {
 		cfg  config.Linters

pkg/printers/tab_test.go

@@ -78,7 +78,8 @@ path/to/fileb.go:300:9  another issue
 			desc:            "enable all options",
 			printLinterName: true,
 			useColors:       true,
-			expected:        "\x1b[1mpath/to/filea.go:10\x1b[0m:4   linter-a  \x1b[31msome issue\x1b[0m\n\x1b[1mpath/to/fileb.go:300\x1b[0m:9  linter-b  \x1b[31manother issue\x1b[0m\n",
+			//nolint:lll // color characters must be in a simple string.
+			expected: "\x1b[1mpath/to/filea.go:10\x1b[0m:4   linter-a  \x1b[31msome issue\x1b[0m\n\x1b[1mpath/to/fileb.go:300\x1b[0m:9  linter-b  \x1b[31manother issue\x1b[0m\n",
 		},
 	}
 

pkg/printers/text_test.go

@@ -97,7 +97,8 @@ func foo() {
 			printIssuedLine: true,
 			printLinterName: true,
 			useColors:       true,
-			expected:        "\x1b[1mpath/to/filea.go:10\x1b[0m:4: \x1b[31msome issue\x1b[0m (linter-a)\n\x1b[1mpath/to/fileb.go:300\x1b[0m:9: \x1b[31manother issue\x1b[0m (linter-b)\nfunc foo() {\n\tfmt.Println(\"bar\")\n}\n",
+			//nolint:lll // color characters must be in a simple string.
+			expected: "\x1b[1mpath/to/filea.go:10\x1b[0m:4: \x1b[31msome issue\x1b[0m (linter-a)\n\x1b[1mpath/to/fileb.go:300\x1b[0m:9: \x1b[31manother issue\x1b[0m (linter-b)\nfunc foo() {\n\tfmt.Println(\"bar\")\n}\n",
 		},
 		{
 			desc:            "disable all options",

test/enabled_linters_test.go

@@ -10,7 +10,6 @@ import (
 	"github.com/golangci/golangci-lint/test/testshared"
 )
 
-//nolint:funlen
 func TestEnabledLinters(t *testing.T) {
 	// require to display the message "Active x linters: [x,y]"
 	t.Setenv(lintersdb.EnvTestRun, "1")

test/testshared/analysis_test.go

@@ -8,7 +8,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-//nolint:funlen
 func Test_parseComments(t *testing.T) {
 	testCases := []struct {
 		filename string

test/testshared/runner_test.go

@@ -9,7 +9,6 @@ import (
 	"github.com/golangci/golangci-lint/pkg/exitcodes"
 )
 
-//nolint:funlen
 func TestRunnerBuilder_Runner(t *testing.T) {
 	testCases := []struct {
 		desc     string