tests: add more tests

Author: ldez

pkg/printers/tab_test.go

@@ -6,6 +6,7 @@ import (
 	"go/token"
 	"testing"
 
+	"github.com/fatih/color"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
@@ -14,6 +15,13 @@ import (
 )
 
 func TestTab_Print(t *testing.T) {
+	// force color globally
+	backup := color.NoColor
+	t.Cleanup(func() {
+		color.NoColor = backup
+	})
+	color.NoColor = false
+
 	issues := []result.Issue{
 		{
 			FromLinter: "linter-a",
@@ -44,16 +52,49 @@ func TestTab_Print(t *testing.T) {
 		},
 	}
 
-	buf := new(bytes.Buffer)
+	testCases := []struct {
+		desc            string
+		printLinterName bool
+		useColors       bool
+		expected        string
+	}{
+		{
+			desc:            "with linter name",
+			printLinterName: true,
+			useColors:       false,
+			expected: `path/to/filea.go:10:4   linter-a  some issue
+path/to/fileb.go:300:9  linter-b  another issue
+`,
+		},
+		{
+			desc:            "disable all options",
+			printLinterName: false,
+			useColors:       false,
+			expected: `path/to/filea.go:10:4   some issue
+path/to/fileb.go:300:9  another issue
+`,
+		},
+		{
+			desc:            "enable all options",
+			printLinterName: true,
+			useColors:       true,
+			expected:        "\x1b[1mpath/to/filea.go:10\x1b[0m:4   linter-a  \x1b[31msome issue\x1b[0m\n\x1b[1mpath/to/fileb.go:300\x1b[0m:9  linter-b  \x1b[31manother issue\x1b[0m\n",
+		},
+	}
+
+	for _, test := range testCases {
+		test := test
+		t.Run(test.desc, func(t *testing.T) {
+			t.Parallel()
 
-	printer := NewTab(true, false, logutils.NewStderrLog(logutils.DebugKeyEmpty), buf)
+			buf := new(bytes.Buffer)
 
-	err := printer.Print(context.Background(), issues)
-	require.NoError(t, err)
+			printer := NewTab(test.printLinterName, test.useColors, logutils.NewStderrLog(logutils.DebugKeyEmpty), buf)
 
-	expected := `path/to/filea.go:10:4   linter-a  some issue
-path/to/fileb.go:300:9  linter-b  another issue
-`
+			err := printer.Print(context.Background(), issues)
+			require.NoError(t, err)
 
-	assert.Equal(t, expected, buf.String())
+			assert.Equal(t, test.expected, buf.String())
+		})
+	}
 }

pkg/printers/text_test.go

@@ -6,6 +6,7 @@ import (
 	"go/token"
 	"testing"
 
+	"github.com/fatih/color"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
@@ -14,6 +15,13 @@ import (
 )
 
 func TestText_Print(t *testing.T) {
+	// force color globally
+	backup := color.NoColor
+	t.Cleanup(func() {
+		color.NoColor = backup
+	})
+	color.NoColor = false
+
 	issues := []result.Issue{
 		{
 			FromLinter: "linter-a",
@@ -44,19 +52,77 @@ func TestText_Print(t *testing.T) {
 		},
 	}
 
-	buf := new(bytes.Buffer)
-
-	printer := NewText(true, false, true, logutils.NewStderrLog(logutils.DebugKeyEmpty), buf)
-
-	err := printer.Print(context.Background(), issues)
-	require.NoError(t, err)
-
-	expected := `path/to/filea.go:10:4: some issue (linter-a)
+	testCases := []struct {
+		desc            string
+		printIssuedLine bool
+		printLinterName bool
+		useColors       bool
+		expected        string
+	}{
+		{
+			desc:            "printIssuedLine and printLinterName",
+			printIssuedLine: true,
+			printLinterName: true,
+			useColors:       false,
+			expected: `path/to/filea.go:10:4: some issue (linter-a)
+path/to/fileb.go:300:9: another issue (linter-b)
+func foo() {
+	fmt.Println("bar")
+}
+`,
+		},
+		{
+			desc:            "printLinterName only",
+			printIssuedLine: false,
+			printLinterName: true,
+			useColors:       false,
+			expected: `path/to/filea.go:10:4: some issue (linter-a)
 path/to/fileb.go:300:9: another issue (linter-b)
+`,
+		},
+		{
+			desc:            "printIssuedLine only",
+			printIssuedLine: true,
+			printLinterName: false,
+			useColors:       false,
+			expected: `path/to/filea.go:10:4: some issue
+path/to/fileb.go:300:9: another issue
 func foo() {
 	fmt.Println("bar")
 }
-`
+`,
+		},
+		{
+			desc:            "enable all options",
+			printIssuedLine: true,
+			printLinterName: true,
+			useColors:       true,
+			expected:        "\x1b[1mpath/to/filea.go:10\x1b[0m:4: \x1b[31msome issue\x1b[0m (linter-a)\n\x1b[1mpath/to/fileb.go:300\x1b[0m:9: \x1b[31manother issue\x1b[0m (linter-b)\nfunc foo() {\n\tfmt.Println(\"bar\")\n}\n",
+		},
+		{
+			desc:            "disable all options",
+			printIssuedLine: false,
+			printLinterName: false,
+			useColors:       false,
+			expected: `path/to/filea.go:10:4: some issue
+path/to/fileb.go:300:9: another issue
+`,
+		},
+	}
+
+	for _, test := range testCases {
+		test := test
+		t.Run(test.desc, func(t *testing.T) {
+			t.Parallel()
+
+			buf := new(bytes.Buffer)
 
-	assert.Equal(t, expected, buf.String())
+			printer := NewText(test.printIssuedLine, test.useColors, test.printLinterName, logutils.NewStderrLog(logutils.DebugKeyEmpty), buf)
+
+			err := printer.Print(context.Background(), issues)
+			require.NoError(t, err)
+
+			assert.Equal(t, test.expected, buf.String())
+		})
+	}
 }