feat: add rewrite option #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a real PR description? |
|
@ldez done |
|
When a PR is not ready:
When a PR is open, a review can start, each commit after the opening of the PR requires another review. Fixing a typo or adding a comment is not a problem but 2600dff is not expected 2 hours after the opening of the PR. |
|
sorry, it's ready to be reviewed now. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci/golangci-lint#3171
this PR add a
func RunRewrite(filename string, needSimplify bool, rewrite string) ([]byte, error)to supportgofmt's-rflag.The caller from
golangci-lintwill use newly added methodRunRewriteto apply a option rewrite rule.empty string as
rewritewill be ignored.private methods are added because origin impl has
os.Exit(...)