fix header item style #3
Conversation
Since the doc of go1.6, the default margin-top of list tag has been 0.5rem not 0 by the embedded style, so assert the same style as the embedded style in stylesheet and re-set the default margin-top to the first of Header-menuItem overwriting the margin-top of it in no media queries. Fixes golang/go#33718
The search input in header has the same problem as that of the first of header menu item, so re-set the default margin-top to it.
googlebot
added
the
cla: yes
|
This PR (HEAD: 1de9d0e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/190997 to see it. Tip: You can toggle comments from me using the |
The default style of list tag has also been as it is outside of the media queries since go1.6, so move it to the outside.
|
This PR (HEAD: 11472e9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/190997 to see it. Tip: You can toggle comments from me using the |
|
Message from Andrew Bonventre: Patch Set 3: I'd rather we remove the inline style from the release notes or have it be more specific via class names. Please don’t reply on this GitHub thread. Visit golang.org/cl/190997. |
|
Message from Koki Tomoshige: Patch Set 3:
Certainly. So is it ok to close this CL? Please don’t reply on this GitHub thread. Visit golang.org/cl/190997. |
|
Message from Alberto Donizetti: Patch Set 3:
Yes, I think it's okay to close here. Please don’t reply on this GitHub thread. Visit golang.org/cl/190997. |
|
Closed in favor of golang/go#33738 |
|
This PR is being closed because golang.org/cl/190997 has been abandoned. abandoned in favor of https://golang.org/issue/33738 |
Since the doc of go1.6, the default margin-top of list tag has been 0.5rem not 0 by the embedded style, so assert the same style as the embedded one in stylesheet and re-set the default margin-top to the elements with this problem.
Fixes golang/go#33718