extension/src/goTest: do not open Debug Console when debug.internalConsoleOptions is neverOpen #3601

rprtr258 · 2024-11-13T18:58:59Z

Reference: microsoft/vscode#11372 (not vscode's bug, but of extension)

gopherbot · 2024-11-13T19:07:16Z

This PR (HEAD: e8df273) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/627675.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-13T19:14:47Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-13T19:22:38Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:21:04Z

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:21:05Z

Message from Hyang-Ah Hana Kim:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:30:46Z

Message from kokoro:

Patch Set 1:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/4810c4fd-5b77-4f88-9db1-abf18d1fad83

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:30:46Z

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/4810c4fd-5b77-4f88-9db1-abf18d1fad83

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:30:46Z

Message from kokoro:

Patch Set 1: kokoro-CI-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/4810c4fd-5b77-4f88-9db1-abf18d1fad83

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T19:55:07Z

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T19:55:08Z

Message from Hyang-Ah Hana Kim:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:03:33Z

Message from kokoro:

Patch Set 2:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/66c9ccc7-0ad1-471e-9223-a5ec5ef94428

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:03:33Z

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/66c9ccc7-0ad1-471e-9223-a5ec5ef94428

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:03:34Z

Message from kokoro:

Patch Set 2: kokoro-CI-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/66c9ccc7-0ad1-471e-9223-a5ec5ef94428

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-15T18:28:25Z

Message from Hyang-Ah Hana Kim:

Patch Set 3: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-15T18:36:12Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/4393abab-d421-4afa-befb-4be56d8fda5e

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-15T18:36:13Z

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/4393abab-d421-4afa-befb-4be56d8fda5e

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-15T18:44:02Z

Message from kokoro:

Patch Set 3: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/4393abab-d421-4afa-befb-4be56d8fda5e

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T15:38:52Z

Message from Hongxiang Jiang:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T22:27:19Z

Message from Hyang-Ah Hana Kim:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

…nsoleOptions is neverOpen Reference: microsoft/vscode#11372 (not vscode's bug, but of extension) Change-Id: I5f5ff6c22d6017c27601987b517aed664b9481b0 GitHub-Last-Rev: e8df273 GitHub-Pull-Request: #3601 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/627675 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> kokoro-CI: kokoro <[email protected]> Reviewed-by: Hongxiang Jiang <[email protected]> Commit-Queue: Hyang-Ah Hana Kim <[email protected]> Auto-Submit: Hyang-Ah Hana Kim <[email protected]>

gopherbot · 2024-11-18T22:34:58Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/fbf1d719-bbc9-4b39-acbc-6ffdeeeba363

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T22:34:58Z

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/fbf1d719-bbc9-4b39-acbc-6ffdeeeba363

Please don’t reply on this GitHub thread. Visit golang.org/cl/627675.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T22:43:12Z

This PR is being closed because golang.org/cl/627675 has been merged.

[master] fix open terminal on debug test

e8df273

rprtr258 changed the title ~~[master] fix open terminal on debug test~~ [master] fix open terminal on debug test when debug.internalConsoleOptions is set to neverOpen Nov 13, 2024

rprtr258 changed the title ~~[master] fix open terminal on debug test when debug.internalConsoleOptions is set to neverOpen~~ fix open terminal on debug test when debug.internalConsoleOptions is set to neverOpen Nov 13, 2024

hyangah changed the title ~~fix open terminal on debug test when debug.internalConsoleOptions is set to neverOpen~~ extension/src/goTest: do not open Debug Console when debug.internalConsoleOptions is neverOpen Nov 14, 2024

gopherbot closed this Nov 18, 2024

extension/src/goTest: do not open Debug Console when debug.internalConsoleOptions is neverOpen #3601

extension/src/goTest: do not open Debug Console when debug.internalConsoleOptions is neverOpen #3601

Uh oh!

Conversation

rprtr258 commented Nov 13, 2024 • edited by hyangah Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Nov 13, 2024

Uh oh!

gopherbot commented Nov 13, 2024

Uh oh!

gopherbot commented Nov 13, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 14, 2024

Uh oh!

gopherbot commented Nov 15, 2024

Uh oh!

gopherbot commented Nov 15, 2024

Uh oh!

gopherbot commented Nov 15, 2024

Uh oh!

gopherbot commented Nov 15, 2024

Uh oh!

gopherbot commented Nov 18, 2024

Uh oh!

gopherbot commented Nov 18, 2024

Uh oh!

gopherbot commented Nov 18, 2024

Uh oh!

gopherbot commented Nov 18, 2024

Uh oh!

gopherbot commented Nov 18, 2024

Uh oh!

Uh oh!

rprtr258 commented Nov 13, 2024 •

edited by hyangah

Loading