Skip to content

Allow go modules in analysis #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow go modules in analysis #430

wants to merge 1 commit into from

Conversation

romaindoumenc
Copy link

@romaindoumenc romaindoumenc commented Mar 16, 2023

As mentioned in golang/go#37054 , the current analyzer forces a GOPATH environment set-up.
Changing this to default to modules (while still allowing environment variable to revert to GOPATH is needed).

@gopherbot
Copy link
Contributor

This PR (HEAD: 5f81103) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/476855 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@romaindoumenc
Copy link
Author

Closing as this is a partial change – so it probably won’t do. Doing a full version first.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/476855.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants