gopls/internal/lsp: add go to implementation support for function types #412
Conversation
|
This PR (HEAD: 79b5e63) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it. Tip: You can toggle comments from me using the |
|
Message from Robert Findley: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
Message from Alan Donovan: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
This PR (HEAD: 952df4b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it. Tip: You can toggle comments from me using the |
|
Message from Adrian Hesketh: Patch Set 2: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
Message from Alan Donovan: Patch Set 2: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
This PR (HEAD: 02be885) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it. Tip: You can toggle comments from me using the |
|
Message from Adrian Hesketh: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
Refactor, taking into account initial code review comments. Fixes #56572
Improve test. Fixes #56572
a-h
force-pushed
the
issue_56572_go_to_implementation_for_funcs
branch
from
02be885 to
c978bed
Compare
|
This PR (HEAD: c978bed) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it. Tip: You can toggle comments from me using the |
|
Message from Adrian Hesketh: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
Hey @gopherbot - how come you haven't picked up the latest commit yet? |
Fixes #56572 fix: add null check from commit 13648cd
a-h
force-pushed
the
issue_56572_go_to_implementation_for_funcs
branch
from
405f74b to
1dc58ee
Compare
|
This PR (HEAD: 1dc58ee) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it. Tip: You can toggle comments from me using the |
|
Message from Adrian Hesketh: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
Message from Alan Donovan: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
Message from Alan Donovan: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
Message from Adrian Hesketh: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. |
|
Does it work with generics? |
|
I took a break from it to try and understand the Go language spec better, because I felt that I didn't fully understand all the points coming back the code review, and now it's out of date. I did think about getting back to this at some point. There's no generic test case, so this PR might not. |
Fixes #56572