Skip to content

x/tools: print check misses concatenated strings #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AlexanderYastrebov
Copy link
Contributor

@gopherbot
Copy link
Contributor

This PR (HEAD: 3c93a47) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/356830 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Zvonimir Pavlinovic:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/5f3da968-b8cf-4a47-8ffb-c7aacbe97092


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/5f3da968-b8cf-4a47-8ffb-c7aacbe97092


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Zvonimir Pavlinovic:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Zvonimir Pavlinovic:

Patch Set 1: Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 1: Code-Review+1 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3ee8e18) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/356830 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Alexander Yastrebov:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 2: Run-TryBot+1 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/9623805f-8b96-408c-b3d9-fb919248c3af


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 2: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/9623805f-8b96-408c-b3d9-fb919248c3af


Please don’t reply on this GitHub thread. Visit golang.org/cl/356830.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 2, 2021
Fixes golang/go#30436

Change-Id: I5b843e65b2188040a1ea5f17e1756b57babb0c22
GitHub-Last-Rev: 3ee8e18
GitHub-Pull-Request: #344
Reviewed-on: https://go-review.googlesource.com/c/tools/+/356830
Trust: Tim King <[email protected]>
Trust: Zvonimir Pavlinovic <[email protected]>
Run-TryBot: Tim King <[email protected]>
gopls-CI: kokoro <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Zvonimir Pavlinovic <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/356830 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/vet: printf check misses strings that are + together
2 participants