Skip to content

gopls/doc: Neovim v0.5 is now stable #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

GGCristo
Copy link
Contributor

@GGCristo GGCristo commented Jul 5, 2021

No description provided.

@google-cla
Copy link

google-cla bot commented Jul 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 5, 2021
@GGCristo
Copy link
Contributor Author

GGCristo commented Jul 5, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 5, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 5ce2282) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/332849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@GGCristo GGCristo changed the title Neovim v0.5 is now stable gopls/doc: Neovim v0.5 is now stable Jul 5, 2021
@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 5c20230) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/332849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/646f52d9-829f-4c19-af20-f5ce76e19cb6


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 3: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/646f52d9-829f-4c19-af20-f5ce76e19cb6


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 3: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/332849.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 12, 2021
Change-Id: Ia3078f9d321d17681b92fd9b00f6dd1cb3eff6d0
GitHub-Last-Rev: 5c20230
GitHub-Pull-Request: #329
Reviewed-on: https://go-review.googlesource.com/c/tools/+/332849
Reviewed-by: Rebecca Stambler <[email protected]>
Trust: Rebecca Stambler <[email protected]>
Trust: Cherry Mui <[email protected]>
Run-TryBot: Rebecca Stambler <[email protected]>
gopls-CI: kokoro <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/332849 has been merged.

@gopherbot gopherbot closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants