internal/lsp: added a fill struct code action #220

luciolas · 2020-04-07T08:15:11Z

This code action generates key-value pairs of fields and default values between a struct's enclosing braces.

Fixes #37576

gopherbot · 2020-04-07T08:19:16Z

This PR (HEAD: f84d949) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-04-07T08:21:56Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-08T05:50:54Z

Message from Rebecca Stambler:

Patch Set 1:

(4 comments)

Thanks for your contribution! See comments below.

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-08T16:02:21Z

Message from Rebecca Stambler:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-09T05:47:02Z

This PR (HEAD: c6b1485) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-04-09T06:13:32Z

This PR (HEAD: 7d5dac2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-04-09T06:24:35Z

Message from Pei-Xian Chee:

Patch Set 3:

(4 comments)

Patch Set 1:

(4 comments)

Thanks for your contribution! See comments below.

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-09T06:41:43Z

Message from Yasuhiro MATSUMOTO:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-09T11:12:52Z

Message from Pei-Xian Chee:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-09T15:51:45Z

Message from Yasuhiro MATSUMOTO:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-10T23:35:55Z

Message from Rebecca Stambler:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-15T16:05:22Z

Message from Pei-Xian Chee:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-16T03:49:02Z

Message from Rebecca Stambler:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-20T12:28:44Z

This PR (HEAD: b078437) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-04-20T12:51:23Z

Message from Pei-Xian Chee:

Patch Set 4:

(4 comments)

I will start adding feature tests.

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

luciolas · 2020-04-22T07:28:39Z

Link issue: golang/go#37576

gopherbot · 2020-04-26T18:51:27Z

Message from Rebecca Stambler:

Patch Set 4:

(1 comment)

Thanks - this looks better! Some tests would be a good next step - they would probably fit into this code:

tools/internal/lsp/lsp_test.go

Line 372 in f3a5411

    
           func (r *runner) SuggestedFix(t *testing.T, spn span.Span, actionKinds []string) {

.

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-04-28T05:59:45Z

Message from Pei-Xian Chee:

Patch Set 4:

(1 comment)

Patch Set 4:

(1 comment)

Thanks - this looks better! Some tests would be a good next step - they would probably fit into this code:

tools/internal/lsp/lsp_test.go

Line 372 in f3a5411

func (r *runner) SuggestedFix(t *testing.T, spn span.Span, actionKinds []string) {

.

Ok, I will add tests in there.

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-03T05:08:30Z

This PR (HEAD: ee5afb8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-05-07T03:21:07Z

Message from Rebecca Stambler:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-09T17:47:23Z

Message from Pei-Xian Chee:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

luciolas · 2020-05-19T11:17:56Z

@stamblerre Just notifying you that I left a reply over at Gerrit. I just realized there was no email from GerritBot on my reply, so I thought of informing you over at Github.

gopherbot · 2020-05-19T17:37:09Z

Message from Rebecca Stambler:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-30T01:18:14Z

This PR (HEAD: 3fd37e5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-05-30T01:35:51Z

This PR (HEAD: a041375) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-06-01T12:33:15Z

Message from Alisson Bruno:

Patch Set 7: Code-Review+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-06-02T03:36:21Z

Message from Rebecca Stambler:

Patch Set 7:

(3 comments)

Thank you for the changes! I just have a few small comments and then we can get this merged :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-06-03T18:38:16Z

This PR (HEAD: 3f420fa) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

…individual fields and default values between a struct's enclosing braces Fixes #37576

gopherbot · 2020-06-03T18:56:34Z

This PR (HEAD: 0e4db3e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/227437 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-06-03T19:01:00Z

Message from Pei-Xian Chee:

Patch Set 9:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-06-03T19:04:06Z

Message from Rebecca Stambler:

Patch Set 9: Run-TryBot+1 Code-Review+2

Awesome, thank you!

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-06-03T19:04:06Z

Message from Gobot Gobot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e6584fed

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-06-03T19:13:46Z

Message from Gobot Gobot:

Patch Set 9: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/227437.
After addressing review feedback, remember to publish your drafts!

This code action generates key-value pairs of fields and default values between a struct's enclosing braces. Fixes #37576 Change-Id: Ia0555164d2164c2bc90bb9ecabbb55042cdd3846 GitHub-Last-Rev: 0e4db3e GitHub-Pull-Request: #220 Reviewed-on: https://go-review.googlesource.com/c/tools/+/227437 Reviewed-by: Rebecca Stambler <[email protected]> Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

gopherbot · 2020-06-04T04:26:13Z

This PR is being closed because golang.org/cl/227437 has been merged.

googlebot added the cla: yes label Apr 7, 2020

luciolas force-pushed the golang/x/tools/fill-struct branch from ab66547 to f84d949 Compare April 7, 2020 08:17

luciolas force-pushed the golang/x/tools/fill-struct branch from f84d949 to c6b1485 Compare April 9, 2020 05:45

luciolas force-pushed the golang/x/tools/fill-struct branch from c6b1485 to 7d5dac2 Compare April 9, 2020 06:12

luciolas force-pushed the golang/x/tools/fill-struct branch from 7d5dac2 to b078437 Compare April 20, 2020 12:28

luciolas force-pushed the golang/x/tools/fill-struct branch from b078437 to ee5afb8 Compare May 3, 2020 05:07

luciolas force-pushed the golang/x/tools/fill-struct branch from ee5afb8 to 3fd37e5 Compare May 30, 2020 01:16

luciolas force-pushed the golang/x/tools/fill-struct branch from 3fd37e5 to a041375 Compare May 30, 2020 01:34

luciolas force-pushed the golang/x/tools/fill-struct branch from a041375 to 3f420fa Compare June 3, 2020 18:37

internal/lsp: added a code action which generates key-value pairs of …

0e4db3e

…individual fields and default values between a struct's enclosing braces Fixes #37576

luciolas force-pushed the golang/x/tools/fill-struct branch from 3f420fa to 0e4db3e Compare June 3, 2020 18:55

gopherbot closed this Jun 4, 2020

leitzler mentioned this pull request Jun 10, 2020

x/tools/gopls: support fill struct behavior golang/go#37576

Closed

ubombi mentioned this pull request Jun 28, 2020

FillStruct using gopls (feature request) fatih/vim-go#2940

Closed

internal/lsp: added a fill struct code action #220

internal/lsp: added a fill struct code action #220

Uh oh!

Conversation

luciolas commented Apr 7, 2020

Uh oh!

gopherbot commented Apr 7, 2020

Uh oh!

gopherbot commented Apr 7, 2020

Uh oh!

gopherbot commented Apr 8, 2020

Uh oh!

gopherbot commented Apr 8, 2020

Uh oh!

gopherbot commented Apr 9, 2020

Uh oh!

gopherbot commented Apr 9, 2020

Uh oh!

gopherbot commented Apr 9, 2020

Uh oh!

gopherbot commented Apr 9, 2020

Uh oh!

gopherbot commented Apr 9, 2020

Uh oh!

gopherbot commented Apr 9, 2020

Uh oh!

gopherbot commented Apr 10, 2020

Uh oh!

gopherbot commented Apr 15, 2020

Uh oh!

gopherbot commented Apr 16, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

gopherbot commented Apr 20, 2020

Uh oh!

luciolas commented Apr 22, 2020

Uh oh!

gopherbot commented Apr 26, 2020

Uh oh!

gopherbot commented Apr 28, 2020

Uh oh!

gopherbot commented May 3, 2020

Uh oh!

gopherbot commented May 7, 2020

Uh oh!

gopherbot commented May 9, 2020

Uh oh!

luciolas commented May 19, 2020

Uh oh!

gopherbot commented May 19, 2020

Uh oh!

gopherbot commented May 30, 2020

Uh oh!

gopherbot commented May 30, 2020

Uh oh!

gopherbot commented Jun 1, 2020

Uh oh!

gopherbot commented Jun 2, 2020

Uh oh!

gopherbot commented Jun 3, 2020

Uh oh!

gopherbot commented Jun 3, 2020

Uh oh!

gopherbot commented Jun 3, 2020

Uh oh!

gopherbot commented Jun 3, 2020

Uh oh!

gopherbot commented Jun 3, 2020

Uh oh!

gopherbot commented Jun 3, 2020

Uh oh!

gopherbot commented Jun 4, 2020

Uh oh!

Uh oh!