Skip to content

Commit 9bf0e21

Browse files
committed
gopls/internal/test/integration/misc: skip asm test unless a{rm,md}64
Fixes golang/go#68058 Change-Id: I8d2467474f39f1834137f5b4718cdbbca4ac0e81 Reviewed-on: https://go-review.googlesource.com/c/tools/+/593416 Reviewed-by: Michael Pratt <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent f2d2ebe commit 9bf0e21

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

gopls/internal/test/integration/misc/webserver_test.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -431,12 +431,16 @@ func g() {
431431
// Get the report and do some minimal checks for sensible results.
432432
//
433433
// Use only portable instructions below! Remember that
434-
// This is a test of plumbing, not compilation, so
434+
// this is a test of plumbing, not compilation, so
435435
// it's better to skip the tests, rather than refine
436-
// them, on any architecture that gives us trouble.
436+
// them, on any architecture that gives us trouble
437+
// (e.g. uses JAL for CALL, or BL<cc> for RET).
438+
// We conservatively test only on the two most popular
439+
// architectures.
437440
report := get(t, doc.URI)
438441
checkMatch(t, true, report, `TEXT.*example.com/a.f`)
439-
if runtime.GOARCH != "risc64" { // RISC-V uses JAL instead of CALL
442+
switch runtime.GOARCH {
443+
case "amd64", "arm64":
440444
checkMatch(t, true, report, `CALL runtime.printlock`)
441445
checkMatch(t, true, report, `CALL runtime.printstring`)
442446
checkMatch(t, true, report, `CALL runtime.printunlock`)

0 commit comments

Comments
 (0)