Skip to content

Commit f2d2ebe

Browse files
dmitshurgopherbot
authored andcommitted
go/analysis/passes/buildtag: retire Go 1.15 support
Go 1.17 is long since out. Furthermore, CL 516575 added a use of parser.SkipObjectResolution to a file with a go1.16 build constraint. This used to be fine, but not now that vet checks for this (see go.dev/issue/66092) since that API is new to Go 1.17. For golang/go#66092. Change-Id: I749b2aa52e02308415c27028be15a436ee11d95c Reviewed-on: https://go-review.googlesource.com/c/tools/+/593297 Reviewed-by: Michael Matloob <[email protected]> Reviewed-by: Sam Thanawalla <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 1239d04 commit f2d2ebe

File tree

3 files changed

+0
-182
lines changed

3 files changed

+0
-182
lines changed

go/analysis/passes/buildtag/buildtag.go

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
//go:build go1.16
6-
// +build go1.16
7-
85
// Package buildtag defines an Analyzer that checks build tags.
96
package buildtag
107

go/analysis/passes/buildtag/buildtag_old.go

-174
This file was deleted.

go/analysis/passes/buildtag/buildtag_test.go

-5
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
package buildtag_test
66

77
import (
8-
"runtime"
9-
"strings"
108
"testing"
119

1210
"golang.org/x/tools/go/analysis"
@@ -15,9 +13,6 @@ import (
1513
)
1614

1715
func Test(t *testing.T) {
18-
if strings.HasPrefix(runtime.Version(), "go1.") && runtime.Version() < "go1.16" {
19-
t.Skipf("skipping on %v", runtime.Version())
20-
}
2116
analyzer := *buildtag.Analyzer
2217
analyzer.Run = func(pass *analysis.Pass) (interface{}, error) {
2318
defer func() {

0 commit comments

Comments
 (0)