gopls/internal/golang: close open file

adonovan · gopherbot · commit 50b4f1b124a3 · 2024-02-12T19:37:00.000Z
Found while thinking about typestate. Change-Id: Ia98ace4782be34d1201f0ce5c8e536314fc494d7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/563155 Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Commit-Queue: Alan Donovan <adonovan@google.com> Auto-Submit: Alan Donovan <adonovan@google.com>
diff --git a/gopls/internal/golang/gc_annotations.go b/gopls/internal/golang/gc_annotations.go
@@ -34,6 +34,7 @@ func GCOptimizationDetails(ctx context.Context, snapshot *cache.Snapshot, mp *me
 	if err != nil {
 		return nil, err
 	}
+	tmpFile.Close() // ignore error
 	defer os.Remove(tmpFile.Name())
 
 	outDirURI := protocol.URIFromPath(outDir)

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ func GCOptimizationDetails(ctx context.Context, snapshot cache.Snapshot, mp me`
`34`	`34`	`if err != nil {`
`35`	`35`	`return nil, err`
`36`	`36`	`}`
	`37`	`+ tmpFile.Close() // ignore error`
`37`	`38`	`defer os.Remove(tmpFile.Name())`
`38`	`39`
`39`	`40`	`outDirURI := protocol.URIFromPath(outDir)`